Summary

Improve the look of the unified banner's buttons on mobile.

Review Request #14131 — Created Aug. 29, 2024 and submitted Sept. 18, 2024, 9:34 a.m.

Information

Owner

maubin

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Depending on the screen size, the publish/discard buttons on the unified
banner could be squished up against the left side of the screen instead
of being at the top right corner of the banner. This change adds a
left margin to the buttons on mobile to make things look better.

Testing Done

Made sure the buttons looked good in the different draft modes and
tested tapping them.

Commits

Summary	ID
Improve the look of the unified banner's buttons on mobile. Depending on the screen size, the publish/discard buttons on the unified banner could be squished up against the left side of the screen instead of being at the top right corner of the banner. This change adds a left margin to the buttons on mobile to make things look better.	c10076230732228b0678c93395a13f59feea411b

Files

Issues

Description	From	Last Updated
Would @banner-padding be more appropriate? This maps to an Ink CSS variable.	chipx86	Sept. 13, 2024, 4:29 p.m.

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

reviewboard/static/rb/css/ui/banners.less (Diff revision 1)
The issue has been resolved. Show all issues
```
Would @banner-padding be more appropriate? This maps to an Ink CSS variable.
```
1. maubin Sept. 13, 2024, 4:30 p.m.
  Yes I think so.

Commits:

	Summary	ID
	Improve the look of the unified banner's buttons on mobile. Depending on the screen size, the publish/discard buttons on the unified banner could be squished up against the left side of the screen instead of being at the top right corner of the banner. This change adds a left margin to the buttons on mobile to make things look better.	90a7ca241928225da72a5361cbe6b3647104dd28
	Improve the look of the unified banner's buttons on mobile. Depending on the screen size, the publish/discard buttons on the unified banner could be squished up against the left side of the screen instead of being at the top right corner of the banner. This change adds a left margin to the buttons on mobile to make things look better.	c10076230732228b0678c93395a13f59feea411b

Diff:

Revision 2 (+26)

Show changes

reviewboard/static/rb/css/ui/banners.less

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.x (2e995b1)