Modernized function typing in reviewboard/accounts/models.py

Review Request #14106 — Created Aug. 16, 2024 and submitted — Latest diff uploaded

Information

Review Board
master

Reviewers

Modernized function typing in reviewboard/accounts/models.py

No new tests were added, however the entire reviewboard test suite
was run and all previously passing tests still pass.

Diff Revision 3

This is not the most recent revision of the diff. The latest diff is revision 5. See what's changed.

orig
1
2
3
4
5

Commits

First Last Summary ID Author
Modernized function typing in reviewboard/accounts/models.py
Added typing to all the function parameters and return types in every function to bring the file in line with more modern typing standards. Certain type imports were put under a `TYPE_CHECKING`. No new tests were added, however the entire `reviewboard` test suite was run and all previously passing tests still pass.
d72bc111c58e20f2fa7a9a78eac84e1d0f19e14a Daniel

Files

reviewboard/static/rb/js/common/resources/models/repositoryModel.ts
reviewboard/static/rb/js/common/resources/models/reviewGroupModel.ts
reviewboard/static/rb/js/common/resources/models/reviewModel.ts
reviewboard/static/rb/js/common/resources/models/reviewRequestModel.ts
reviewboard/static/rb/js/common/resources/models/screenshotCommentModel.ts Deleted
reviewboard/static/rb/js/common/resources/models/screenshotCommentReplyModel.ts Deleted
reviewboard/static/rb/js/common/resources/models/screenshotModel.ts Deleted
reviewboard/static/rb/js/common/resources/models/userFileAttachmentModel.ts Deleted
reviewboard/static/rb/js/common/resources/models/userModel.ts Deleted
reviewboard/static/rb/js/common/resources/models/validateDiffModel.ts Deleted
reviewboard/static/rb/js/common/resources/models/tests/index.ts
reviewboard/static/rb/js/common/views/clientLoginPageView.ts Deleted
reviewboard/static/rb/js/common/views/tests/clientLoginViewTests.ts Deleted
reviewboard/static/rb/js/common/views/tests/index.ts
reviewboard/static/rb/js/configForms/index.ts
reviewboard/static/rb/js/configForms/models/resourceListItemModel.es6.js Was reviewboard/static/rb/js/configForms/models/resourceListItemModel.ts
reviewboard/static/rb/js/configForms/models/tests/index.ts Deleted
reviewboard/static/rb/js/configForms/models/tests/resourceListItemModelTests.es6.js Was reviewboard/static/rb/js/configForms/models/tests/resourceListItemModelTests.ts
reviewboard/static/rb/js/resources/collections/repositoryBranchesCollection.es6.js
reviewboard/static/rb/js/resources/collections/repositoryCommitsCollection.es6.js Was reviewboard/static/rb/js/common/resources/collections/repositoryCommitsCollection.ts
This diff has been split across 6 pages: < 1 2 3 4 5 6 >
reviewboard/static/rb/js/common/resources/models/repositoryModel.ts
reviewboard/static/rb/js/common/resources/models/reviewGroupModel.ts
reviewboard/static/rb/js/common/resources/models/reviewModel.ts
reviewboard/static/rb/js/common/resources/models/reviewRequestModel.ts
reviewboard/static/rb/js/common/resources/models/screenshotCommentModel.ts
reviewboard/static/rb/js/common/resources/models/screenshotCommentReplyModel.ts
reviewboard/static/rb/js/common/resources/models/screenshotModel.ts
reviewboard/static/rb/js/common/resources/models/userFileAttachmentModel.ts
reviewboard/static/rb/js/common/resources/models/userModel.ts
reviewboard/static/rb/js/common/resources/models/validateDiffModel.ts
reviewboard/static/rb/js/common/resources/models/tests/index.ts
reviewboard/static/rb/js/common/views/clientLoginPageView.ts
reviewboard/static/rb/js/common/views/tests/clientLoginViewTests.ts
reviewboard/static/rb/js/common/views/tests/index.ts
reviewboard/static/rb/js/configForms/index.ts
reviewboard/static/rb/js/configForms/models/resourceListItemModel.ts
reviewboard/static/rb/js/configForms/models/tests/index.ts
reviewboard/static/rb/js/configForms/models/tests/resourceListItemModelTests.ts
reviewboard/static/rb/js/resources/collections/repositoryBranchesCollection.es6.js
reviewboard/static/rb/js/common/resources/collections/repositoryCommitsCollection.ts
This diff has been split across 6 pages: < 1 2 3 4 5 6 >
Loading...