Modernized function typing in reviewboard/accounts/models.py

 






 

 


  Review Request #14106
  —
  Created Aug. 16, 2024 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  dan.casares
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Modernized function typing in reviewboard/accounts/models.py

 








  


 
 

  
No new tests were added, however the entire reviewboard test suite

was run and all previously passing tests still pass.

 







 









 





  








 




 







   

    
    
Changes between revision 2 and 3



    

 

 

 

 
orig
1
2
3
4
5

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Modernized function typing in reviewboard/accounts/models.py
     
Added typing to all the function parameters and return types in every
function to bring the file in line with more modern typing standards.
Certain type imports were put under a `TYPE_CHECKING`.

No new tests were added, however the entire `reviewboard` test suite
was run and all previously passing tests still pass.

    

   
  		
  0149e77fc2277cd24c0c5745e3b32f6c6134e5cc
  Daniel
 


 
  
 
 
  
   
    

     Modernized function typing in reviewboard/accounts/models.py
     
Added typing to all the function parameters and return types in every
function to bring the file in line with more modern typing standards.
Certain type imports were put under a `TYPE_CHECKING`.

No new tests were added, however the entire `reviewboard` test suite
was run and all previously passing tests still pass.

    

   
  		
  d72bc111c58e20f2fa7a9a78eac84e1d0f19e14a
  Daniel
 




    


    


      
Files


      

 
  
 
 
  reviewboard/static/rb/js/resources/models/tests/diffCommentModelTests.es6.js
  
  Was reviewboard/static/rb/js/common/resources/models/tests/diffCommentModelTests.ts
  
 
 
  
   

  
 		


 
  
 
 
  reviewboard/static/rb/js/resources/models/tests/draftReviewRequestModelTests.es6.js
  
  Was reviewboard/static/rb/js/common/resources/models/tests/draftReviewRequestModelTests.ts
  
 
 
  
   

  
 		


 
  
 
 
  reviewboard/static/rb/js/resources/models/tests/fileAttachmentCommentModelTests.es6.js
  
  Was reviewboard/static/rb/js/common/resources/models/tests/fileAttachmentCommentModelTests.ts
  
 
 
  
   

  
 		


 
  
 
 
  reviewboard/static/rb/js/resources/models/tests/fileDiffModelTests.es6.js
  
  Was reviewboard/static/rb/js/common/resources/models/tests/fileDiffModelTests.ts
  
 
 
  
   

  
 		


 
  
 
 
  reviewboard/static/rb/js/resources/models/tests/generalCommentModelTests.es6.js
  
  Was reviewboard/static/rb/js/common/resources/models/tests/generalCommentModelTests.ts
  
 
 
  
   

  
 		


 
  
 
 
  reviewboard/static/rb/js/resources/models/tests/repositoryBranchModelTests.es6.js
  
  Was reviewboard/static/rb/js/common/resources/models/tests/repositoryBranchModelTests.ts
  
 
 
  
   

  
 		


 
  
 
 
  reviewboard/static/rb/js/resources/models/tests/repositoryCommitModelTests.es6.js
  
  Was reviewboard/static/rb/js/common/resources/models/tests/repositoryCommitModelTests.ts
  
 
 
  
   

  
 		


 
  
 
 
  reviewboard/static/rb/js/resources/models/tests/screenshotCommentModelTests.es6.js
  
  Was reviewboard/static/rb/js/common/resources/models/tests/screenshotCommentModelTests.ts
  
 
 
  
   

  
 		


 
  
 
 
  reviewboard/static/rb/js/resources/models/tests/screenshotModelTests.es6.js
  
  Was reviewboard/static/rb/js/common/resources/models/tests/screenshotModelTests.ts
  
 
 
  
   

  
 		


 
  
 
 
  reviewboard/static/rb/js/resources/models/tests/userFileAttachmentModelTests.es6.js
  
  Was reviewboard/static/rb/js/common/resources/models/tests/userFileAttachmentModelTests.ts
  
 
 
  
   

  
 		


 
  
 
 
  reviewboard/static/rb/js/resources/models/tests/validateDiffModelTests.es6.js
  
  Was reviewboard/static/rb/js/common/resources/models/tests/validateDiffModelTests.ts
  
 
 
  
   

  
 		


 
  
 
 
  reviewboard/static/rb/js/reviews/models/commentIssueManagerModel.ts
  
 
 
  
   

  
 		


 
  
 
 
  reviewboard/static/rb/js/reviews/models/diffCommentBlockModel.ts
  
 
 
  
   

  
 		


 
  
 
 
  reviewboard/static/rb/js/reviews/models/fileAttachmentCommentBlockModel.ts
  
 
 
  
   

  
 		


 
  
 
 
  reviewboard/static/rb/js/reviews/models/reviewRequestEditorModel.ts
  
 
 
  
   

  
 		


 
  
 
 
  reviewboard/static/rb/js/reviews/models/screenshotCommentBlockModel.ts
  
 
 
  
   

  
 		


 
  
 
 
  reviewboard/static/rb/js/reviews/models/tests/commentIssueManagerModelTests.ts
  
 
 
  
   

  
 		


 
  
 
 
  reviewboard/static/rb/js/reviews/views/abstractCommentBlockView.ts
  
 
 
  
   

  
 		


 
  
 
 
  reviewboard/static/rb/js/reviews/views/diffViewerPageView.ts
  
 
 
  
   

  
 		


 
  
 
 
  reviewboard/static/rb/js/reviews/views/fileAttachmentThumbnailView.ts
  
 
 
  
   

  
 		


    

    

 This diff has been split across 6 pages:
 
  <
 
 
  
   1
  
 
  
   2
  
 
  
   3
  
 
  
   4
  
 
  
   5
  
 
  
   6
  
 
 
  >
 


   

  

 









 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/models/tests/diffCommentModelTests.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/models/tests/draftReviewRequestModelTests.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/models/tests/fileAttachmentCommentModelTests.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/models/tests/fileDiffModelTests.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/models/tests/generalCommentModelTests.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/models/tests/repositoryBranchModelTests.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/models/tests/repositoryCommitModelTests.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/models/tests/screenshotCommentModelTests.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/models/tests/screenshotModelTests.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/models/tests/userFileAttachmentModelTests.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/resources/models/tests/validateDiffModelTests.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/models/commentIssueManagerModel.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/models/diffCommentBlockModel.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/models/fileAttachmentCommentBlockModel.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/models/reviewRequestEditorModel.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/models/screenshotCommentBlockModel.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/models/tests/commentIssueManagerModelTests.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/views/abstractCommentBlockView.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/views/diffViewerPageView.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/views/fileAttachmentThumbnailView.ts
     
    

   
  

 





 This diff has been split across 6 pages:
 
  <
 
 
  
   1
  
 
  
   2
  
 
  
   3
  
 
  
   4
  
 
  
   5
  
 
  
   6
  
 
 
  >
 







     

    

   

  

  

   
   Loading...