• 
      

    Fix a regression from the new setup.py build changes.

    Review Request #14066 — Created July 31, 2024 and submitted

    Information

    Review Board
    release-7.x

    Reviewers

    The new approach for setting up an environment within setup.py develop
    had an issue where the paths within the generated requirements file were
    all relative, but there was no guarantee pip would be run within the
    right directory. This led to invalid file paths.

    We now generate an absolute path for all files within the requirements
    file.

    Tested this change within CI, which hit this problem. Successfully set
    up the development environment.

    Summary ID
    Fix a regression from the new setup.py build changes.
    The new approach for setting up an environment within `setup.py develop` had an issue where the paths within the generated requirements file were all relative, but there was no guarantee `pip` would be run within the right directory. This led to invalid file paths. We now generate an absolute path for all files within the requirements file.
    43ff6d4c9ddc84741918c4dcb2848125d0cadfdf
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (53e1909)