Add typing to reviews/detail.py

Review Request #14019 — Created July 9, 2024 and updated

Information

Review Board
release-7.x

Reviewers

This change adds type hints throughout our ReviewRequestPageData and
entry implementations.

Ran unit tests.

Summary ID
Add typing to reviews/detail.py
This change adds type hints throughout our ReviewRequestPageData and entry implementations. Testing Done: Ran unit tests.
46d0af1834f6d1b8baa631856f0edd845f71ae6e
Description From Last Updated

too many blank lines (3) Column: 1 Error code: E303

reviewbotreviewbot

The attributes section should be removed.

maubinmaubin

Can you add , optional here.

maubinmaubin

Can you add , optional here.

maubinmaubin
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

david
maubin
  1. 
      
  2. reviewboard/reviews/detail.py (Diff revision 2)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
    Show all issues

    The attributes section should be removed.

  3. reviewboard/reviews/detail.py (Diff revision 2)
     
     
    Show all issues

    Can you add , optional here.

  4. reviewboard/reviews/detail.py (Diff revision 2)
     
     
    Show all issues

    Can you add , optional here.

  5. 
      
david
Review request changed
Commits:
Summary ID
Add typing to reviews/detail.py
This change adds type hints throughout our ReviewRequestPageData and entry implementations. Testing Done: Ran unit tests.
a5785e9f5c54c47f0574bd7e89233d359536a34e
Add typing to reviews/detail.py
This change adds type hints throughout our ReviewRequestPageData and entry implementations. Testing Done: Ran unit tests.
46d0af1834f6d1b8baa631856f0edd845f71ae6e

Checks run (2 succeeded)

flake8 passed.
JSHint passed.
maubin
  1. Ship It!
  2.