• 
      

    Don't include draft diffsets in the initial latest timestamp.

    Review Request #14009 — Created July 2, 2024 and submitted

    Information

    Review Board
    release-7.x

    Reviewers

    When we load the diff viewer, we include the latest activity timestamp
    in the page data. This is then used with subsequent accesses to the
    last-update resource to determine whether to show the updates bubble.

    The timestamp of a draft diffset was being included in the initial
    activity timestamp, while it is not included in the timestamp returned
    by the API. This meant that the updates bubble would pop up saying the
    diff was new because the timestamp did not match.

    Loaded the diff viewer with a draft diff (while viewing as an admin
    user). Saw that the updates bubble no longer popped up incorrectly.

    Summary ID
    Don't include draft diffsets in the initial latest timestamp.
    When we load the diff viewer, we include the latest activity timestamp in the page data. This is then used with subsequent accesses to the last-update resource to determine whether to show the updates bubble. The timestamp of a draft diffset was being included in the initial activity timestamp, while it is not included in the timestamp returned by the API. This meant that the updates bubble would pop up saying the diff was new because the timestamp did not match. Testing Done: Loaded the diff viewer with a draft diff (while viewing as an admin user). Saw that the updates bubble no longer popped up incorrectly.
    709976330f20bbd56b267ab86bb0c435e2634dc5
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-7.x (39211d9)