Added backend work for the archive profile setting

Review Request #14003 — Created June 28, 2024 and updated — Latest diff uploaded

Information

Review Board
master

Reviewers

Began backend implementation for a profile setting that will determine whether
to automatically archive a review request when posted.
This included adding a publish_and_archive BooleanField to the
AccountSettingsForm in reviewboard/accounts/pages.py, which is initially set
to False. publish_and_archive was also added to the Profile in
reviewboard/accounts/models.py. Lastly, publish_and_archive was also added to
reviewboard/accounts/accounts.py in the js_user_session_info() function.

A series of tests were also implmeneted to ensure that the AccountSettingsForm
was initialized, loaded, and saved properly and that it correctly identified
invalid inputs. These tests were added to
reviewboard/accounts/test/test_account_settings_form.py.

All previous passing pytests still passed.

Changes between revision 5 and 6

orig
1
2
3
4
5
6
7
8
9
10
11
12
13
14

Commits

Summary ID Author
Added backend work for the archive profile setting
cfe29bb89d2fb5360a79a582cb42ea5c4a73d996 Daniel
Changed publish_and_archive to bee a regular BooleanField.
110645ac302fce03f56b9d7331f8a78ccd4f57c7 Daniel
Added test to test_account_settings_form for previous changes.
d4c8e6df5b28303eee148ab113f92290cebe92ec Daniel
Slight change to single test
c47d6b0ce1e7ac74c8a5fed5a8ee8c01505fd6ca Daniel
removed trailing white space
a5a47c2c5bd39afd1969ac9a6f5ecb5693ca6994 Daniel
Fixing issues highlighted in review.
3912ae510848532175db3e866b8fec70d9539080 Daniel
Removed whitespace
91c2f315aee32a58883b2d361f5ae721b759baa0 Daniel
Changed publish_and_archive to be property and not BooleanField to not be add...
7ea0769c5f44ba49a005ab4dcb9cb49686347346 Daniel
Added backend work for the archive profile setting
30cd3e40f35bf86e5fff334e205b4a9d7c395a32 Daniel
Changed publish_and_archive to bee a regular BooleanField.
f5642d198399b493640a0be29f41c3c60e372bca Daniel
Added test to test_account_settings_form for previous changes.
a75b7f76d0770663b0917cd54619ff2e4c78ce6d Daniel
Slight change to single test
86eafb7560527799c4d0c5bb4c3ee233ff9ae13c Daniel
removed trailing white space
bdaeedea3b36037dd2393783dde199c643a3fd12 Daniel
Fixing issues highlighted in review.
719420e92218e671ce1439a2c5e15ea4c35acb33 Daniel
Removed whitespace
58b864eb6e433f433210aea8c9fb7358ebc55750 Daniel
Changed publish_and_archive to be property and not BooleanField to not be add...
a8f699817a20db342ba4f06e66187efa2deb535d Daniel
Fixed indentation
9a4e5a39cffa34d42733fde47471c07da8b9f6ea Daniel

Files

package-lock.json
docs/releasenotes/7.0.1.rst Deleted
docs/releasenotes/index.rst
reviewboard/dependencies.py
reviewboard/staticbundles.py
reviewboard/accounts/tests/test_template_tags.py
reviewboard/diffviewer/templatetags/difftags.py
reviewboard/site/models.py
reviewboard/static/rb/css/ui/forms.less
reviewboard/static/rb/css/ui/page-topbar.less
reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.es6.js
reviewboard/static/rb/js/common/resources/index.ts
reviewboard/static/rb/js/common/resources/models/baseResourceModel.ts
reviewboard/static/rb/js/common/resources/models/defaultReviewerModel.ts Deleted
reviewboard/static/rb/js/common/resources/models/repositoryModel.ts Deleted
reviewboard/static/rb/js/common/resources/models/reviewRequestModel.ts
reviewboard/static/rb/js/common/resources/models/tests/index.ts
reviewboard/static/rb/js/resources/models/defaultReviewerModel.es6.js
reviewboard/static/rb/js/resources/models/repositoryModel.es6.js
reviewboard/static/rb/js/resources/models/reviewGroupModel.es6.js Was reviewboard/static/rb/js/common/resources/models/reviewGroupModel.ts
reviewboard/static/rb/js/resources/models/tests/defaultReviewerModelTests.es6.js Was reviewboard/static/rb/js/common/resources/models/tests/defaultReviewerModelTests.ts
reviewboard/static/rb/js/resources/models/tests/reviewGroupModelTests.es6.js Was reviewboard/static/rb/js/common/resources/models/tests/reviewGroupModelTests.ts
reviewboard/static/rb/js/reviews/models/regionCommentBlockModel.ts
reviewboard/static/rb/js/reviews/models/reviewablePageModel.ts
reviewboard/static/rb/js/reviews/views/abstractCommentBlockView.ts
reviewboard/static/rb/js/reviews/views/regionCommentBlockView.ts
reviewboard/templates/admin/delete_confirmation.html
package-lock.json
docs/releasenotes/7.0.1.rst
docs/releasenotes/index.rst
reviewboard/dependencies.py
reviewboard/staticbundles.py
reviewboard/accounts/tests/test_template_tags.py
reviewboard/diffviewer/templatetags/difftags.py
reviewboard/site/models.py
reviewboard/static/rb/css/ui/forms.less
reviewboard/static/rb/css/ui/page-topbar.less
reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.es6.js
reviewboard/static/rb/js/common/resources/index.ts
reviewboard/static/rb/js/common/resources/models/baseResourceModel.ts
reviewboard/static/rb/js/common/resources/models/defaultReviewerModel.ts
reviewboard/static/rb/js/common/resources/models/repositoryModel.ts
reviewboard/static/rb/js/common/resources/models/reviewRequestModel.ts
reviewboard/static/rb/js/common/resources/models/tests/index.ts
reviewboard/static/rb/js/resources/models/defaultReviewerModel.es6.js
reviewboard/static/rb/js/resources/models/repositoryModel.es6.js
reviewboard/static/rb/js/common/resources/models/reviewGroupModel.ts
reviewboard/static/rb/js/common/resources/models/tests/defaultReviewerModelTests.ts
reviewboard/static/rb/js/common/resources/models/tests/reviewGroupModelTests.ts
reviewboard/static/rb/js/reviews/models/regionCommentBlockModel.ts
reviewboard/static/rb/js/reviews/models/reviewablePageModel.ts
reviewboard/static/rb/js/reviews/views/abstractCommentBlockView.ts
reviewboard/static/rb/js/reviews/views/regionCommentBlockView.ts
reviewboard/templates/admin/delete_confirmation.html
Loading...