• 
      

    Add new icons for MS Teams and Discord, and improve asset building.

    Review Request #13914 — Created May 31, 2024 and submitted

    Information

    rbintegrations
    release-4.x

    Reviewers

    We've updated the icons for both MS Teams and Discord in our CDN to
    better fit into the rounded avatars in the messages. This change updates
    the assets timestamp to force use of the new images and to specify the
    path for the new MS Teams assets.

    In order to properly leverage the assets timestamp and base URL for the
    logo and trophies without having to overwrite all the attributes, we now
    define logo_url and trophy_urls as cached properties instead of
    attributes. This allows them to be computed dynamically based on any
    overridden asset timestamp/base URLs defined by subclasses.

    Tested the new download assets and generated URLs.

    This will require some testing in production.

    Summary ID
    Add new icons for MS Teams and Discord, and improve asset building.
    We've updated the icons for both MS Teams and Discord in our CDN to better fit into the rounded avatars in the messages. This change updates the assets timestamp to force use of the new images and to specify the path for the new MS Teams assets. In order to properly leverage the assets timestamp and base URL for the logo and trophies without having to overwrite all the attributes, we now define `logo_url` and `trophy_urls` as cached properties instead of attributes. This allows them to be computed dynamically based on any overridden asset timestamp/base URLs defined by subclasses.
    350d69fd42230ae8ad7e3a318b3a63ac974e3ace
    chipx86
    david
    1. Ship It!
    2. 
        
    maubin
    1. Once this is live I'll take a look at my MS Teams and our Slack and Discord integrations to make sure the logos all look OK.

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-4.x (287750e)