post-review: Mercurial client path from .hg/hgrc fixup when path url has http://user@host/repo

Review Request #1390 — Created Feb. 4, 2010 and submitted

Information

RBTools

Reviewers

In cases where the path of a mercurial repository is found from the hgrc file containing:

[paths]
default = http://tsaeger@hg/repo


the path "http://tsaeger@hg/repo" is not found on the reviewboard server, however "http://hg/repo" is.

This patch is a quick cut-n-paste to fix this.

Executing to following produce my diff as expected


$ post-review -d --server=http://reviewboard -n

###.hg/hgrc
[paths]
default = http://tsaeger@hg/repo
TS
Review request changed
Change Summary:
summary change...
Summary:
Mercurial client path from .hg/hgrc fixup when path url has http://user@host/repo
post-review: Mercurial client path from .hg/hgrc fixup when path url has http://user@host/repo
chipx86
  1. Now that we have this same logic in two places, can you instead consolidate that logic into a common place?
    1. Very true.  I'll work on simplifying.
    2. I've committed this patch to master (ddfec21) as I'm working on pushing out a release. I'd still like to get a patch to commonize it, but it can be a new change on top of what's committed. Going to close out this review request.
      
      Thanks!
  2. 
      
WA
  1. Ship It!
  2.