Add dark mode support for the Review Dialog.

Review Request #13855 — Created May 14, 2024 and submitted

Information

Review Board
release-7.x

Reviewers

This is a big update to the Review Dialog, adding dark mode support and
fixing up layout issues.

All the buttons have been replaced with Ink buttons. The Publish button
is now marked as Primary, adding a visual indicator to it. Likewise,
Discard is marked as Danger.

Rather than applying margins to various elements to control spacing, we
now use a flexbox for the parent containers for comments along with a
gap. Any empty containers are hidden from view, in order to avoid extra
spacing.

The orange header labels are now green, which stands out better in dark
mode and also better conveys a draft.

Tested all aspects and comment types in the Review Dialog in both light
and dark modes.

Tested all Publish options.

Tested discarding.

Tested adding a general comment within the dialog.

Tested closing.

Summary ID
Add dark mode support for the Review Dialog.
This is a big update to the Review Dialog, adding dark mode support and fixing up layout issues. All the buttons have been replaced with Ink buttons. The Publish button is now marked as Primary, adding a visual indicator to it. Likewise, Discard is marked as Danger. Rather than applying margins to various elements to control spacing, we now use a flexbox for the parent containers for comments along with a gap. Any empty containers are hidden from view, in order to avoid extra spacing. The orange header labels are now green, which stands out better in dark mode and also better conveys a draft.
a177a44ee6cbdfd56e14ec7d5b9cd127e18adfce

chipx86
david
  1. Ship It!
  2. 
      
maubin
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-7.x (ed72aa7)
Loading...