Update DialogView to use Ink buttons.

 






 

 


  Review Request #13844
  —
  Created May 8, 2024 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Review Board
 









 
 

  release-7.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
DialogView now constructs Ink buttons based on the provided button data.

This replaces the old input-type buttons, giving us buttons that work

well in dark mode.

 








  


 
 

  
Unit tests passed.


Tested various dialogs based on DialogView in both light and dark

modes.

 







 









 





  








 




 







   

    
    
Changes between revision 1 and 2



    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Update DialogView to use Ink buttons.
     
DialogView now constructs Ink buttons based on the provided button data.
This replaces the old `input`-type buttons, giving us buttons that work
well in dark mode.

    

   
  		
  478282f509e62046d9d0873394a390ba8802c527
  Christian Hammond
 


 
  
 
 
  
   
    

     Update DialogView to use Ink buttons.
     
DialogView now constructs Ink buttons based on the provided button data.
This replaces the old `input`-type buttons, giving us buttons that work
well in dark mode.

    

   
  		
  57c3c67ec27e47aea6408fc4f538a38a822ad5a0
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/static/rb/js/ui/views/dialogView.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/ui/views/tests/dialogViewTests.es6.js
     
    

   
  

 










     

    

   

  

  

   
   Loading...