Update DialogView to use Ink buttons.

Review Request #13844 — Created May 8, 2024 and submitted

Information

Review Board
release-7.x

Reviewers

DialogView now constructs Ink buttons based on the provided button data.
This replaces the old input-type buttons, giving us buttons that work
well in dark mode.

Unit tests passed.

Tested various dialogs based on DialogView in both light and dark
modes.

Summary ID
Update DialogView to use Ink buttons.
DialogView now constructs Ink buttons based on the provided button data. This replaces the old `input`-type buttons, giving us buttons that work well in dark mode.
57c3c67ec27e47aea6408fc4f538a38a822ad5a0

Description From Last Updated

['disabled'] is better written in dot notation. Column: 28 Error code: W069

reviewbotreviewbot

['type'] is better written in dot notation. Column: 28 Error code: W069

reviewbotreviewbot

['type'] is better written in dot notation. Column: 28 Error code: W069

reviewbotreviewbot

['onClick'] is better written in dot notation. Column: 28 Error code: W069

reviewbotreviewbot

Missing semicolon. Column: 59 Error code: W033

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 passed.
JSHint failed.

JSHint

chipx86
maubin
  1. Ship It!
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-7.x (a5da5c3)
Loading...