Update DialogView to use Ink buttons.

 






 

 


  Review Request #13844
  —
  Created May 8, 2024 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Review Board
 









 
 

  release-7.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
DialogView now constructs Ink buttons based on the provided button data.

This replaces the old input-type buttons, giving us buttons that work

well in dark mode.

 








  


 
 

  
Unit tests passed.


Tested various dialogs based on DialogView in both light and dark

modes.

 







 









 





  








 




 







   

    
    
Diff Revision 1


This is not the most recent revision of the diff. The latest diff is revision 2. See what's changed.

    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Update DialogView to use Ink buttons.
     
DialogView now constructs Ink buttons based on the provided button data.
This replaces the old `input`-type buttons, giving us buttons that work
well in dark mode.

    

   
  		
  478282f509e62046d9d0873394a390ba8802c527
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/static/rb/js/ui/views/dialogView.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/ui/views/tests/dialogViewTests.es6.js
     
    

   
  

 










     

    

   

  

  

   
   Loading...