Update the Unified Banner's discard confirmation dialog for Ink.

Review Request #13841 — Created May 8, 2024 and submitted

Information

Review Board
release-7.x

Reviewers

The Unified Banner's discard confirmation dialog now creates Ink
buttons instead of input-based buttons, ensuring we have a consistent
style for the dialog.

One notable difference in behavior is that Ink buttons don't propagate
click events when an onClick handler is registered, so we now need to
ensure we close the dialog when clicked.

Tested the dialog on light and dark mode.

Tested both the Cancel and Discard buttons, making sure that Cancel closed
the dialog and Discard correctly discarded and reloaded the page.

Summary ID
Update the Unified Banner's discard confirmation dialog for Ink.
The Unified Banner's discard confirmation dialog now creates Ink buttons instead of `input`-based buttons, ensuring we have a consistent style for the dialog. One notable difference in behavior is that Ink buttons don't propagate click events when an `onClick` handler is registered, so we now need to ensure we close the dialog when clicked.
e559a1cf03815bf122318d477a8a5fa6591828d1

maubin
  1. Ship It!
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-7.x (aac48ef)
Loading...