Update the Upload Diff view and dialog for dark mode.

Review Request #13840 — Created May 8, 2024 and submitted

Information

Review Board
release-7.x

Reviewers

The Upload Diff view is now styled to use Ink buttons (properly
centered alongside text) and to properly show text in dark mode.

Tested uploading bad diffs, non-diffs, and valid diffs to the
review request in both light and dark modes.

Summary ID
Update the Upload Diff view and dialog for dark mode.
The Upload Diff view is now styled to use Ink buttons (properly centered alongside text) and to properly show text in dark mode.
5d1d59202f6b92997d2bfc7b6eb9c9b026db6f05

Description From Last Updated

I think I remember seeing in one of your other changes that we have a new warning icon. If that's …

maubinmaubin
maubin
  1. 
      
  2. Show all issues

    I think I remember seeing in one of your other changes that we have a new warning icon. If that's true, should we switch over to using it here?

    1. this is actually a couple icons ago :(

      I didn't want to touch the content of that dialog any more than I had to at this point. There were other styling issues in there, and it may be better served using an alert component or something. Let's track it, but I think it's low-priority given where we are in the release.

    2. Got it, sounds good.

  3. 
      
maubin
  1. 
      
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-7.x (7c00dec)