Summary

Update the Upload Diff view and dialog for dark mode.

Review Request #13840 — Created May 8, 2024 and submitted May 8, 2024, 11 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The Upload Diff view is now styled to use Ink buttons (properly
centered alongside text) and to properly show text in dark mode.

Testing Done

Tested uploading bad diffs, non-diffs, and valid diffs to the
review request in both light and dark modes.

Commits

Summary	ID
Update the Upload Diff view and dialog for dark mode. The Upload Diff view is now styled to use Ink buttons (properly centered alongside text) and to properly show text in dark mode.	5d1d59202f6b92997d2bfc7b6eb9c9b026db6f05

Files

Issues

Description	From	Last Updated
I think I remember seeing in one of your other changes that we have a new warning icon. If that's …	maubin	May 8, 2024, 8:42 p.m.

flake8 passed.

JSHint passed.

Error (light mode) (Revision 1)

The issue has been dropped. Show all issues

I think I remember seeing in one of your other changes that we have a new warning icon. If that's true, should we switch over to using it here?

chipx86 May 8, 2024, 3:43 p.m.

this is actually a couple icons ago :(

I didn't want to touch the content of that dialog any more than I had to at this point. There were other styling issues in there, and it may be better served using an alert component or something. Let's track it, but I think it's low-priority given where we are in the release.

maubin May 8, 2024, 8:42 p.m.
```
Got it, sounds good.
```

Ship it!

Status: Closed (submitted)

Change Summary:

Pushed to release-7.x (7c00dec)