Update Ink spacing usage for the new adjustments.

Review Request #13828 — Created May 6, 2024 and submitted

Information

Review Board
release-7.x

Reviewers

Ink's spacing tokens have been updated to be based on a medium=1em
scaling, and with all sizes above m being updated to be far more
useful for layout.

This impacted a few places in the UI: Banners, trophies, and issue bars.
This change fixes those up, using more appropriate tokens and ensuring
layout looks correct.

Grepped the codebase for usage of the affected units. Checked and updated
what I saw.

There may be further changes as we work on the codebase.

Summary ID
Update Ink spacing usage for the new adjustments.
Ink's spacing tokens have been updated to be based on a medium=1em scaling, and with all sizes above `m` being updated to be far more useful for layout. This impacted a few places in the UI: Banners, trophies, and issue bars. This change fixes those up, using more appropriate tokens and ensuring layout looks correct.
3e4433fbaa993433017675a4cadc7a8840e41fb6

Description From Last Updated

Can we align the top of the drop-down with the bottom of the banner? This is pretty stair-steppy.

daviddavid
david
  1. 
      
  2. Show all issues

    Can we align the top of the drop-down with the bottom of the banner? This is pretty stair-steppy.

    1. Turns out this wasn't a regression in this change, but likely in my original Ink work for the banner. I'll track this and look into it separately as polish.

  3. 
      
maubin
  1. Ship It!
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-7.x (4a86ddb)