Summary

Remove deprecated-for-5.0 code from Djblets.

Review Request #13812 — Created May 2, 2024 and submitted May 4, 2024, 10:13 p.m.

Information

Owner

david

Repository

Djblets

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

This change removes the rest of the APIs and usage that has been marked
as deprecated and removed for Djblets 5.0. This also turns on subquery
and join type checking by default for assertQueries, as was advertised
in the deprecation warnings for those. This required updating one unit
test for the join types, but otherwise works.

Testing Done

Ran Djblets and Review Board unit tests.

Commits

Summary	ID
Remove deprecated-for-5.0 code from Djblets. This change removes the rest of the APIs and usage that has been marked as deprecated and removed for Djblets 5.0. This also turns on subquery and join type checking by default for `assertQueries`, as was advertised in the deprecation warnings for those. This required updating one unit test for the join types, but otherwise works. Testing Done: Ran Djblets and Review Board unit tests.	c8eb4e7089c56910511b42374a33e9f5ca82e060

Summary

Remove deprecated-for-5.0 code from Djblets.

This change removes the rest of the APIs and usage that has been marked as deprecated and removed for Djblets 5.0. This also turns on subquery and join type checking by default for `assertQueries`, as was advertised in the deprecation warnings for those. This required updating one unit test for the join types, but otherwise works. Testing Done: Ran Djblets and Review Board unit tests.

c8eb4e7089c56910511b42374a33e9f5ca82e060

Issues

Description	From	Last Updated
Let's quadruple-check that we don't ship anything anywhere that uses this.	chipx86	May 2, 2024, 4:29 p.m.
Indentation is inconsistent here.	chipx86	May 3, 2024, 6:08 p.m.
I think we should be checking for/asserting on these, rather than assuming. We're not defensive enough in the JavaScript codebase.	chipx86	May 2, 2024, 4:55 p.m.
Shouldn't this be RemovedInDjblets60Warning?	maubin	May 3, 2024, 6:07 p.m.

flake8 passed.

JSHint passed.

djblets/log/__init__.py (Diff revision 1)

The issue has been resolved. Show all issues

Let's quadruple-check that we don't ship anything anywhere that uses this.

david May 2, 2024, 4:01 p.m.

Just re-audited all of our codebases and I don't see any. That said, I'm okay bringing this back if you think it's too risky.

chipx86 May 2, 2024, 4:02 p.m.

Let's bring it back for now, just to be overly-safe. At this point in the release, I'm concerned about any new work with the capability to break anything.

(Almost tempted to say we just leave all these deprecations for 6.0.)

david May 2, 2024, 4:04 p.m.

The rest of these should all be much safer and more obvious.

djblets/static/djblets/js/configForms/models/listItemModel.ts (Diff revision 1)

The issue has been resolved. Show all issues

I think we should be checking for/asserting on these, rather than assuming. We're not defensive enough in the JavaScript codebase.

Change Summary:


Restored request= paramater to logging methods and changed the removal warning to say Djblets 7.0, to give this one a lot more time.
Removed obsolete python collections compat file.

Commits:

	Summary	ID
	Remove deprecated-for-5.0 code from Djblets. This change removes the rest of the APIs and usage that has been marked as deprecated and removed for Djblets 5.0. This also turns on subquery and join type checking by default for `assertQueries`, as was advertised in the deprecation warnings for those. This required updating one unit test for the join types, but otherwise works. Testing Done: - Ran Djblets and Review Board unit tests.	74d6ab6c8c1ef18c95997e380d89628848480015
	Remove deprecated-for-5.0 code from Djblets. This change removes the rest of the APIs and usage that has been marked as deprecated and removed for Djblets 5.0. This also turns on subquery and join type checking by default for `assertQueries`, as was advertised in the deprecation warnings for those. This required updating one unit test for the join types, but otherwise works. Testing Done: Ran Djblets and Review Board unit tests.	95d9ddbb6ea86c65d88cf2487559e2636f2d315b

Diff:

Revision 2 (+72 -434)

Show changes

	djblets/deprecation.py
	djblets/datagrid/grids.py
	djblets/datagrid/tests.py
	djblets/log/__init__.py
	djblets/pipeline/settings.py
	djblets/static/djblets/js/configForms/models/listItemModel.ts
	djblets/testing/testcases.py
	djblets/util/properties.py
	1 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

djblets/deprecation.py (Diff revision 2)

The issue has been dropped. Show all issues

Shouldn't this be RemovedInDjblets60Warning?

david May 3, 2024, 10:30 a.m.

Because this one is particularly annoying, I thought it best to give it even more time.

chipx86 May 3, 2024, 5:42 p.m.

In general, I'd like to give a 2 release window for deprecations anyway. That said, I don't know whether "Next" should be next-major-version or next-deprecation-removal-from-this-major-version. I feel like it should be "next major version" though, given the naming.

chipx86 May 3, 2024, 5:43 p.m.

This is really meant for consumers of the library, and not in deprecation calls, fwiw.

Ship it!

```
Ship It!
```

djblets/static/djblets/js/configForms/models/listItemModel.ts (Diff revisions 1 - 2)
The issue has been resolved. Show all issues
```
Indentation is inconsistent here.
```

Commits:

	Summary	ID
	Remove deprecated-for-5.0 code from Djblets. This change removes the rest of the APIs and usage that has been marked as deprecated and removed for Djblets 5.0. This also turns on subquery and join type checking by default for `assertQueries`, as was advertised in the deprecation warnings for those. This required updating one unit test for the join types, but otherwise works. Testing Done: Ran Djblets and Review Board unit tests.	95d9ddbb6ea86c65d88cf2487559e2636f2d315b
	Remove deprecated-for-5.0 code from Djblets. This change removes the rest of the APIs and usage that has been marked as deprecated and removed for Djblets 5.0. This also turns on subquery and join type checking by default for `assertQueries`, as was advertised in the deprecation warnings for those. This required updating one unit test for the join types, but otherwise works. Testing Done: Ran Djblets and Review Board unit tests.	b625d0cfeb48cab2505205193a2645934fdb508a

Diff:

Revision 3 (+72 -434)

Show changes

	djblets/deprecation.py
	djblets/datagrid/grids.py
	djblets/datagrid/tests.py
	djblets/log/__init__.py
	djblets/pipeline/settings.py
	djblets/static/djblets/js/configForms/models/listItemModel.ts
	djblets/testing/testcases.py
	djblets/util/properties.py
	1 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

	Summary	ID
	Remove deprecated-for-5.0 code from Djblets. This change removes the rest of the APIs and usage that has been marked as deprecated and removed for Djblets 5.0. This also turns on subquery and join type checking by default for `assertQueries`, as was advertised in the deprecation warnings for those. This required updating one unit test for the join types, but otherwise works. Testing Done: Ran Djblets and Review Board unit tests.	b625d0cfeb48cab2505205193a2645934fdb508a
	Remove deprecated-for-5.0 code from Djblets. This change removes the rest of the APIs and usage that has been marked as deprecated and removed for Djblets 5.0. This also turns on subquery and join type checking by default for `assertQueries`, as was advertised in the deprecation warnings for those. This required updating one unit test for the join types, but otherwise works. Testing Done: Ran Djblets and Review Board unit tests.	c8eb4e7089c56910511b42374a33e9f5ca82e060

Diff:

Revision 4 (+72 -434)

Show changes

	djblets/deprecation.py
	djblets/datagrid/grids.py
	djblets/datagrid/tests.py
	djblets/log/__init__.py
	djblets/pipeline/settings.py
	djblets/static/djblets/js/configForms/models/listItemModel.ts
	djblets/testing/testcases.py
	djblets/util/properties.py
	1 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.x (5fb05c7)