Remove deprecated-for-5.0 code from Djblets.

 






 

 


  Review Request #13812
  —
  Created May 2, 2024 and submitted 

 




















 

  

   Information

  





 
 

  david
 









 
 

  Djblets
 









 
 

  release-5.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  djblets
 









 
 

  
 






 








 





  


 
 

  
This change removes the rest of the APIs and usage that has been marked

as deprecated and removed for Djblets 5.0. This also turns on subquery

and join type checking by default for assertQueries, as was advertised

in the deprecation warnings for those. This required updating one unit

test for the join types, but otherwise works.

 








  


 
 

  
Ran Djblets and Review Board unit tests.

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     

      Remove deprecated-for-5.0 code from Djblets.
      
This change removes the rest of the APIs and usage that has been marked
as deprecated and removed for Djblets 5.0. This also turns on subquery
and join type checking by default for `assertQueries`, as was advertised
in the deprecation warnings for those. This required updating one unit
test for the join types, but otherwise works.

Testing Done:
Ran Djblets and Review Board unit tests.

     


    		
    c8eb4e7089c56910511b42374a33e9f5ca82e060

   



  
 




 













 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
Let's quadruple-check that we don't ship anything anywhere that uses this.

      		
      
       chipx86chipx86
      
      
       
      
     




     

      
       
       
Indentation is inconsistent here.

      		
      
       chipx86chipx86
      
      
       
      
     




     

      
       
       
I think we should be checking for/asserting on these, rather than assuming. We're not defensive enough in the JavaScript codebase.

      		
      
       chipx86chipx86
      
      
       
      
     




     

      
       
       
Shouldn't this be RemovedInDjblets60Warning?

      		
      
       maubinmaubin
      
      
       
      
     


    
   

  

 







 






  

 



















 




 




 














 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       djblets/log/__init__.py
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

     
     
    

     
     
    

     
     
    

     
     
    

     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    Let's quadruple-check that we don't ship anything anywhere that uses this.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Just re-audited all of our codebases and I don't see any. That said, I'm okay bringing this back if you think it's too risky.
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      Let's bring it back for now, just to be overly-safe. At this point in the release, I'm concerned about any new work with the capability to break anything.
      

      (Almost tempted to say we just leave all these deprecations for 6.0.)
      
 
      

      3. 



    3. 
 
 
      
 
      
  
 
      
 
      
  
      The rest of these should all be much safer and more obvious.
      
 
      

      4. 


 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       djblets/static/djblets/js/configForms/models/listItemModel.ts
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

     
     
    

     
     
    

     
     
    

     
     
    

     
     
    

     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    I think we should be checking for/asserting on these, rather than assuming. We're not defensive enough in the JavaScript codebase.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  4. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    5. 




  

 
















 



 

  

   




david




   

   

  

 



 















 





 

  

   




maubin




   

   







  

 



 

  


   

   

    
 
maubin


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       djblets/deprecation.py
       


        (Diff revision 2)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    Shouldn't this be RemovedInDjblets60Warning?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Because this one is particularly annoying, I thought it best to give it even more time.
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      In general, I'd like to give a 2 release window for deprecations anyway. That said, I don't know whether "Next" should be next-major-version or next-deprecation-removal-from-this-major-version. I feel like it should be "next major version" though, given the naming.
      
 
      

      3. 



    3. 
 
 
      
 
      
  
 
      
 
      
  
      This is really meant for consumers of the library, and not in deprecation calls, fwiw.
      
 
      

      4. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 





 

  

   




maubin




   

   







  

 



 

  


   

   

    
 
maubin


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       djblets/static/djblets/js/configForms/models/listItemModel.ts
       


        (Diff revisions 1 - 2)


       
      
     
    
        
    
     
     
    

     
     
    

     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    Indentation is inconsistent here.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




david




   

   

  

 



 















 



 

  

   




david




   

   

  

 



 















 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




david




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  







  

   

    Status:
   

   


    Completed

   

  




  

   

    Change Summary:
   

   

    
Pushed to release-5.x (5fb05c7)