Fix up a bunch of lint issues.

Review Request #13805 — Created April 30, 2024 and submitted

Information

Review Board
release-7.x

Reviewers

This change fixes up a bunch of mostly-harmless linter errors. The vast
majority of these are unused imports or variable assignments that are
never used.

Ran unit tests.

Summary ID
Fix up a bunch of lint issues.
This change fixes up a bunch of mostly-harmless linter errors. The vast majority of these are unused imports or variable assignments that are never used. Testing Done: Ran unit tests. Reviewed at https://reviews.reviewboard.org/r/13805/
261ff4a341b1fdd19a4f6193eca636c8c27b614d
Description From Last Updated

I don't think we need this anymore. The problem was that Django 1.11 used legacy imports that were gone in …

chipx86chipx86

module level import not at top of file Column: 1 Error code: E402

reviewbotreviewbot

I don't think we actually need this at all anymore.

chipx86chipx86

What's this upset about?

chipx86chipx86
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

maubin
  1. Ship It!
  2. 
      
chipx86
  1. 
      
  2. reviewboard/cmdline/rbext.py (Diff revision 1)
     
     
     
     
    Show all issues

    I don't think we need this anymore.

    The problem was that Django 1.11 used legacy imports that were gone in Python 3.10. Newer versions used the correct imports.

  3. reviewboard/manage.py (Diff revision 1)
     
     
     
    Show all issues

    I don't think we actually need this at all anymore.

  4. Show all issues

    What's this upset about?

    1. It's a warning that l is a bad variable name (I guess 4-deep nested loops are probably a smell)

    2. Mind adding a comment above it about the noqa? I wouldn't have guessed.

  5. 
      
david
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-7.x (261ff4a)