Summary

Fix up a bunch of lint issues.

Review Request #13805 — Created April 30, 2024 and submitted May 3, 2024, 9:31 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change fixes up a bunch of mostly-harmless linter errors. The vast
majority of these are unused imports or variable assignments that are
never used.

Testing Done

Ran unit tests.

Commits

Summary	ID
Fix up a bunch of lint issues. This change fixes up a bunch of mostly-harmless linter errors. The vast majority of these are unused imports or variable assignments that are never used. Testing Done: Ran unit tests. Reviewed at https://reviews.reviewboard.org/r/13805/	261ff4a341b1fdd19a4f6193eca636c8c27b614d

Issues

Description	From	Last Updated
I don't think we need this anymore. The problem was that Django 1.11 used legacy imports that were gone in …	chipx86	May 2, 2024, 3:20 p.m.
module level import not at top of file Column: 1 Error code: E402	reviewbot	April 30, 2024, 5:04 p.m.
I don't think we actually need this at all anymore.	chipx86	May 2, 2024, 3:20 p.m.
What's this upset about?	chipx86	May 2, 2024, 3:19 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/cmdline/rbext.py (Diff revision 1)
The issue has been dropped. Show all issues
```
module level import not at top of file

Column: 1
Error code: E402
```

Ship it!

```
Ship It!
```

reviewboard/cmdline/rbext.py (Diff revision 1)

The issue has been resolved. Show all issues

I don't think we need this anymore.

The problem was that Django 1.11 used legacy imports that were gone in Python 3.10. Newer versions used the correct imports.

reviewboard/manage.py (Diff revision 1)
The issue has been resolved. Show all issues
```
I don't think we actually need this at all anymore.
```

reviewboard/reviews/management/commands/fill-database.py (Diff revision 1)

The issue has been dropped. Show all issues

What's this upset about?

david May 2, 2024, 3:21 p.m.

It's a warning that l is a bad variable name (I guess 4-deep nested loops are probably a smell)

chipx86 May 3, 2024, 5:38 p.m.

Mind adding a comment above it about the noqa? I wouldn't have guessed.

Commits:

	Summary	ID
	Fix up a bunch of lint issues. This change fixes up a bunch of mostly-harmless linter errors. The vast majority of these are unused imports or variable assignments that are never used. Testing Done: Ran unit tests.	10c1320c2a307ced0ff49154de2fdedcdb2d2f9b
	Fix up a bunch of lint issues. This change fixes up a bunch of mostly-harmless linter errors. The vast majority of these are unused imports or variable assignments that are never used. Testing Done: Ran unit tests. Reviewed at https://reviews.reviewboard.org/r/13805/	f6ed350d95865057a027dcb1fa4495fa963ff11f

Diff:

Revision 2 (+82 -208)

Show changes

	reviewboard/deprecation.py
	reviewboard/manage.py
	reviewboard/settings.py
	reviewboard/test.py
	reviewboard/accounts/views.py
	reviewboard/accounts/sso/views.py
	reviewboard/admin/widgets.py
	reviewboard/admin/forms/search_settings.py
	55 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

	Summary	ID
	Fix up a bunch of lint issues. This change fixes up a bunch of mostly-harmless linter errors. The vast majority of these are unused imports or variable assignments that are never used. Testing Done: Ran unit tests. Reviewed at https://reviews.reviewboard.org/r/13805/	f6ed350d95865057a027dcb1fa4495fa963ff11f
	Fix up a bunch of lint issues. This change fixes up a bunch of mostly-harmless linter errors. The vast majority of these are unused imports or variable assignments that are never used. Testing Done: Ran unit tests. Reviewed at https://reviews.reviewboard.org/r/13805/	261ff4a341b1fdd19a4f6193eca636c8c27b614d

Diff:

Revision 3 (+86 -208)

Show changes

	reviewboard/deprecation.py
	reviewboard/manage.py
	reviewboard/settings.py
	reviewboard/test.py
	reviewboard/accounts/views.py
	reviewboard/accounts/sso/views.py
	reviewboard/admin/widgets.py
	reviewboard/admin/forms/search_settings.py
	55 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.x (261ff4a)