Simplify review dialog saving.

Review Request #13790 — Created April 25, 2024 and submitted

Information

Review Board
release-7.x

Reviewers

The review dialog save/publish operation used our ancient $.funcQueue,
and was overly complex as a result. All of the component operations are
now promise-based, so this change updates that operation to use
async/await instead.

  • Ran js-tests.
  • Created a draft review and opened all the editors inside the review
    dialog. Hit publish and saw that each of the editors saved and then
    the review was published correctly.
Summary ID
Simplify review dialog saving.
The review dialog save/publish operation used our ancient `$.funcQueue`, and was overly complex as a result. All of the component operations are now promise-based, so this change updates that operation to use async/await instead. Testing Done: - Ran js-tests. - Created a draft review and opened all the editors inside the review dialog. Hit publish and saw that each of the editors saved and then the review was published correctly.
aaeedd41b39e0c4c31bae629ddb0bd76905b9403
maubin
  1. Ship It!
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-7.x (c630638)