Summary

Simplify review dialog saving.

Review Request #13790 — Created April 25, 2024 and submitted April 25, 2024, 8:38 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The review dialog save/publish operation used our ancient $.funcQueue,
and was overly complex as a result. All of the component operations are
now promise-based, so this change updates that operation to use
async/await instead.

Testing Done


Ran js-tests.
Created a draft review and opened all the editors inside the review

  dialog. Hit publish and saw that each of the editors saved and then

  the review was published correctly.

Commits

Summary	ID
Simplify review dialog saving. The review dialog save/publish operation used our ancient `$.funcQueue`, and was overly complex as a result. All of the component operations are now promise-based, so this change updates that operation to use async/await instead. Testing Done: - Ran js-tests. - Created a draft review and opened all the editors inside the review dialog. Hit publish and saw that each of the editors saved and then the review was published correctly.	aaeedd41b39e0c4c31bae629ddb0bd76905b9403

Summary

Simplify review dialog saving.

The review dialog save/publish operation used our ancient `$.funcQueue`, and was overly complex as a result. All of the component operations are now promise-based, so this change updates that operation to use async/await instead. Testing Done: - Ran js-tests. - Created a draft review and opened all the editors inside the review dialog. Hit publish and saw that each of the editors saved and then the review was published correctly.

aaeedd41b39e0c4c31bae629ddb0bd76905b9403

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.x (c630638)