Summary

Don't try to upload source for new binary files added in child diffs.

Review Request #13771 — Created April 22, 2024 and submitted April 22, 2024, 10:17 p.m.

Information

Owner

david

Repository

RBTools

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

The fix to upload source versions of binary files when posting changes
that include parent diffs ended up causing warnings when attempting to
post a change that added a new binary file.

This change adds a check so we don't try to upload the source version of
a binary file if the source revision is PRE-CREATION.

Testing Done

Created a branch on top of another branch and made a commit that added a
new binary file. Posted the diff between the two branches and saw that I
did not see any warnings about trying to get the file content at the
PRE-CREATION revision.

Commits

Summary	ID
Don't try to upload source for new binary files added in child diffs. The fix to upload source versions of binary files when posting changes that include parent diffs ended up causing warnings when attempting to post a change that added a new binary file. This change adds a check so we don't try to upload the source version of a binary file if the source revision is PRE-CREATION. Testing Done: Created a branch on top of another branch and made a commit that added a new binary file. Posted the diff between the two branches and saw that I did not see any warnings about trying to get the file content at the PRE-CREATION revision.	6d5a4137a0d4fc47bb5b40bdcaf10b752ef6f66c

Summary

Don't try to upload source for new binary files added in child diffs.

The fix to upload source versions of binary files when posting changes that include parent diffs ended up causing warnings when attempting to post a change that added a new binary file. This change adds a check so we don't try to upload the source version of a binary file if the source revision is PRE-CREATION. Testing Done: Created a branch on top of another branch and made a commit that added a new binary file. Posted the diff between the two branches and saw that I did not see any warnings about trying to get the file content at the PRE-CREATION revision.

6d5a4137a0d4fc47bb5b40bdcaf10b752ef6f66c

Issues

Description	From	Last Updated
Is this "PRE-CREATION" string Git-specific? Does this apply and work with other SCMs?	maubin	April 22, 2024, 8:27 p.m.

flake8 passed.

JSHint passed.

rbtools/commands/post.py (Diff revision 1)

The issue has been dropped. Show all issues

Is this "PRE-CREATION" string Git-specific? Does this apply and work with other SCMs?

david April 22, 2024, 8:26 p.m.

It comes from the PRE_CREATION revision definition in reviewboard/scmtools/core.py

maubin April 22, 2024, 8:32 p.m.
```
Ah got it.
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.x (1f42ab5)