Don't try to upload source for new binary files added in child diffs.

Review Request #13771 — Created April 22, 2024 and submitted

Information

RBTools
release-5.x

Reviewers

The fix to upload source versions of binary files when posting changes
that include parent diffs ended up causing warnings when attempting to
post a change that added a new binary file.

This change adds a check so we don't try to upload the source version of
a binary file if the source revision is PRE-CREATION.

Created a branch on top of another branch and made a commit that added a
new binary file. Posted the diff between the two branches and saw that I
did not see any warnings about trying to get the file content at the
PRE-CREATION revision.

Summary ID
Don't try to upload source for new binary files added in child diffs.
The fix to upload source versions of binary files when posting changes that include parent diffs ended up causing warnings when attempting to post a change that added a new binary file. This change adds a check so we don't try to upload the source version of a binary file if the source revision is PRE-CREATION. Testing Done: Created a branch on top of another branch and made a commit that added a new binary file. Posted the diff between the two branches and saw that I did not see any warnings about trying to get the file content at the PRE-CREATION revision.
6d5a4137a0d4fc47bb5b40bdcaf10b752ef6f66c
Description From Last Updated

Is this "PRE-CREATION" string Git-specific? Does this apply and work with other SCMs?

maubinmaubin
maubin
  1. 
      
  2. rbtools/commands/post.py (Diff revision 1)
     
     
    Show all issues

    Is this "PRE-CREATION" string Git-specific? Does this apply and work with other SCMs?

    1. It comes from the PRE_CREATION revision definition in reviewboard/scmtools/core.py

    2. Ah got it.

  3. 
      
maubin
  1. 
      
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-5.x (1f42ab5)