Fix commits list with draft diffs.

Review Request #13770 — Created April 22, 2024 and submitted — Latest diff uploaded

Information

Review Board
release-7.x

Reviewers

When viewing a draft diff, the commits list in the diff viewer would not
render properly. This was happening because the query for all commits
was not including the draft diffset. This change fixes that up and adds
unit tests for the two cases of published diff and draft diff.

  • Verified that I could view the commits list for a draft diff.
  • Ran unit tests.

Diff Revision 1

This is not the most recent revision of the diff. The latest diff is revision 2. See what's changed.

orig
1
2

Commits

First Last Summary ID Author
Fix commits list with draft diffs.
When viewing a draft diff, the commits list in the diff viewer would not render properly. This was happening because the query for all commits was not including the draft diffset. This change fixes that up and adds unit tests for the two cases of published diff and draft diff. Testing Done: - Verified that I could view the commits list for a draft diff. - Ran unit tests.
6ea42700efb99e1db636fad8cd618d7217bae56c David Trowbridge
reviewboard/reviews/tests/test_reviews_diff_viewer_view.py
reviewboard/reviews/views/diffviewer.py
Loading...