Fix commits list with draft diffs.

Review Request #13770 — Created April 22, 2024 and submitted

Information

Review Board
release-7.x

Reviewers

When viewing a draft diff, the commits list in the diff viewer would not
render properly. This was happening because the query for all commits
was not including the draft diffset. This change fixes that up and adds
unit tests for the two cases of published diff and draft diff.

  • Verified that I could view the commits list for a draft diff.
  • Ran unit tests.
Summary ID
Fix commits list with draft diffs.
When viewing a draft diff, the commits list in the diff viewer would not render properly. This was happening because the query for all commits was not including the draft diffset. This change fixes that up and adds unit tests for the two cases of published diff and draft diff. Testing Done: - Verified that I could view the commits list for a draft diff. - Ran unit tests.
d63105d28db9935e39c9715bfb01a6a96aad62de
Description From Last Updated

local variable 'commit' is assigned to but never used Column: 9 Error code: F841

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

david
maubin
  1. Ship It!
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-7.x (c74afa8)