Summary

Fix commits list with draft diffs.

Review Request #13770 — Created April 22, 2024 and submitted April 22, 2024, 8:27 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

When viewing a draft diff, the commits list in the diff viewer would not
render properly. This was happening because the query for all commits
was not including the draft diffset. This change fixes that up and adds
unit tests for the two cases of published diff and draft diff.

Testing Done


Verified that I could view the commits list for a draft diff.
Ran unit tests.

Commits

Summary	ID
Fix commits list with draft diffs. When viewing a draft diff, the commits list in the diff viewer would not render properly. This was happening because the query for all commits was not including the draft diffset. This change fixes that up and adds unit tests for the two cases of published diff and draft diff. Testing Done: - Verified that I could view the commits list for a draft diff. - Ran unit tests.	d63105d28db9935e39c9715bfb01a6a96aad62de

Summary

Fix commits list with draft diffs.

When viewing a draft diff, the commits list in the diff viewer would not render properly. This was happening because the query for all commits was not including the draft diffset. This change fixes that up and adds unit tests for the two cases of published diff and draft diff. Testing Done: - Verified that I could view the commits list for a draft diff. - Ran unit tests.

d63105d28db9935e39c9715bfb01a6a96aad62de

Issues

Description	From	Last Updated
local variable 'commit' is assigned to but never used Column: 9 Error code: F841	reviewbot	April 22, 2024, 1:53 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/tests/test_reviews_diff_viewer_view.py (Diff revision 1)
The issue has been dropped. Show all issues
```
local variable 'commit' is assigned to but never used

Column: 9
Error code: F841
```

Commits:

	Summary	ID
	Fix commits list with draft diffs. When viewing a draft diff, the commits list in the diff viewer would not render properly. This was happening because the query for all commits was not including the draft diffset. This change fixes that up and adds unit tests for the two cases of published diff and draft diff. Testing Done: - Verified that I could view the commits list for a draft diff. - Ran unit tests.	6ea42700efb99e1db636fad8cd618d7217bae56c
	Fix commits list with draft diffs. When viewing a draft diff, the commits list in the diff viewer would not render properly. This was happening because the query for all commits was not including the draft diffset. This change fixes that up and adds unit tests for the two cases of published diff and draft diff. Testing Done: - Verified that I could view the commits list for a draft diff. - Ran unit tests.	d63105d28db9935e39c9715bfb01a6a96aad62de

Diff:

Revision 2 (+192 -2)

Show changes

	reviewboard/reviews/tests/test_reviews_diff_viewer_view.py
	reviewboard/reviews/views/diffviewer.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-7.x (c74afa8)