Fix regressions in packaging extensions.

Review Request #13762 — Created April 20, 2024 and submitted — Latest diff uploaded

Information

Djblets
release-5.x

Reviewers

The rewrites for modern extension packaging had some regressions when
working off of a clean source tree and when processing lists of
entrypoints.

We had assumed the build/lib directory existed, but that wasn't a
guarantee at this point. This is now created when we need it.

We also assumed the extension's static directory existed, and broke if
it didn't. We now simply skip static media building in this case.

For the entrypoints, we now check if the result is a list or a string.
In either case, we convert to a string with an entrypoint per line, for
processing.

Successfully built rbintegrations and Power Pack packages.

Changes between revision 1 and 2

orig
1
2

Commits

Summary ID Author
Fix regressions in packaging extensions.
The rewrites for modern extension packaging had some regressions when working off of a clean source tree and when processing lists of entrypoints. We had assumed the `build/lib` directory existed, but that wasn't a guarantee at this point. This is now created when we need it. For the entrypoints, we now check if the result is a list or a string. In either case, we convert to a string with an entrypoint per line, for processing.
09fca51a92541a6be447e6f60c6721d6f5e1bd3e Christian Hammond
Fix regressions in packaging extensions.
The rewrites for modern extension packaging had some regressions when working off of a clean source tree and when processing lists of entrypoints. We had assumed the `build/lib` directory existed, but that wasn't a guarantee at this point. This is now created when we need it. We also assumed the extension's `static` directory existed, and broke if it didn't. We now simply skip static media building in this case. For the entrypoints, we now check if the result is a list or a string. In either case, we convert to a string with an entrypoint per line, for processing.
3b0a0ba56410650642d69bca74bd053e0f5fa05f Christian Hammond
djblets/extensions/packaging/setuptools_backend.py
Loading...