Summary

Fix regressions in packaging extensions.

Review Request #13762 — Created April 20, 2024 and submitted April 25, 2024, 1:45 a.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

The rewrites for modern extension packaging had some regressions when

working off of a clean source tree and when processing lists of

entrypoints.
We had assumed the build/lib directory existed, but that wasn't a

guarantee at this point. This is now created when we need it.
We also assumed the extension's static directory existed, and broke if

it didn't. We now simply skip static media building in this case.
For the entrypoints, we now check if the result is a list or a string.

In either case, we convert to a string with an entrypoint per line, for

processing.

Testing Done

Successfully built rbintegrations and Power Pack packages.

Commits

Summary	ID
Fix regressions in packaging extensions. The rewrites for modern extension packaging had some regressions when working off of a clean source tree and when processing lists of entrypoints. We had assumed the `build/lib` directory existed, but that wasn't a guarantee at this point. This is now created when we need it. We also assumed the extension's `static` directory existed, and broke if it didn't. We now simply skip static media building in this case. For the entrypoints, we now check if the result is a list or a string. In either case, we convert to a string with an entrypoint per line, for processing.	3b0a0ba56410650642d69bca74bd053e0f5fa05f

Summary

Fix regressions in packaging extensions.

The rewrites for modern extension packaging had some regressions when working off of a clean source tree and when processing lists of entrypoints. We had assumed the `build/lib` directory existed, but that wasn't a guarantee at this point. This is now created when we need it. We also assumed the extension's `static` directory existed, and broke if it didn't. We now simply skip static media building in this case. For the entrypoints, we now check if the result is a list or a string. In either case, we convert to a string with an entrypoint per line, for processing.

3b0a0ba56410650642d69bca74bd053e0f5fa05f

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Change Summary:

Updated to fix an issue with extensions that don't provide static media files.

Description:

		The rewrites for modern extension packaging had some regressions when
		working off of a clean source tree and when processing lists of
		entrypoints.

		We had assumed the `build/lib` directory existed, but that wasn't a
		guarantee at this point. This is now created when we need it.

	+	We also assumed the extension's `static` directory existed, and broke if
	+	it didn't. We now simply skip static media building in this case.
	+
		For the entrypoints, we now check if the result is a list or a string.
		In either case, we convert to a string with an entrypoint per line, for
		processing.

Commits:

	Summary	ID
	Fix regressions in packaging extensions. The rewrites for modern extension packaging had some regressions when working off of a clean source tree and when processing lists of entrypoints. We had assumed the `build/lib` directory existed, but that wasn't a guarantee at this point. This is now created when we need it. For the entrypoints, we now check if the result is a list or a string. In either case, we convert to a string with an entrypoint per line, for processing.	09fca51a92541a6be447e6f60c6721d6f5e1bd3e
	Fix regressions in packaging extensions. The rewrites for modern extension packaging had some regressions when working off of a clean source tree and when processing lists of entrypoints. We had assumed the `build/lib` directory existed, but that wasn't a guarantee at this point. This is now created when we need it. We also assumed the extension's `static` directory existed, and broke if it didn't. We now simply skip static media building in this case. For the entrypoints, we now check if the result is a list or a string. In either case, we convert to a string with an entrypoint per line, for processing.	3b0a0ba56410650642d69bca74bd053e0f5fa05f

Diff:

Revision 2 (+26 -4)

Show changes

djblets/extensions/packaging/setuptools_backend.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.x (f4d8c50)