Summary

Fix unit test regressions from recent UI changes.

Review Request #13754 — Created April 19, 2024 and submitted April 20, 2024, 9:02 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Some of my recent changes impacted some of our Python unit tests. I was
a bit sloppy in not running the Python tests for some changes,
concentrating more on the JavaScript side.

These were mostly string changes that affected comparisons, though there
was one piece of broken HTML introduced in menu_action.html.

These have all been fixed, and all Python tests now pass.

Testing Done

Unit tests pass.

Commits

Summary	ID
Fix unit test regressions from recent UI changes. Some of my recent changes impacted some of our Python unit tests. I was a bit sloppy in not running the Python tests for some changes, concentrating more on the JavaScript side. These were mostly string changes that affected comparisons, though there was one piece of broken HTML introduced in `menu_action.html`. These have all been fixed, and all Python tests now pass.	4c7d877469bff5f2c02e48dd525266a194a55778

Summary

Fix unit test regressions from recent UI changes.

Some of my recent changes impacted some of our Python unit tests. I was a bit sloppy in not running the Python tests for some changes, concentrating more on the JavaScript side. These were mostly string changes that affected comparisons, though there was one piece of broken HTML introduced in `menu_action.html`. These have all been fixed, and all Python tests now pass.

4c7d877469bff5f2c02e48dd525266a194a55778

Issues

Description	From	Last Updated
continuation line over-indented for visual indent Column: 15 Error code: E127	reviewbot	April 19, 2024, 1:07 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/extensions/tests/test_navigation_bar_hook.py (Diff revision 1)
The issue has been resolved. Show all issues
```
continuation line over-indented for visual indent

Column: 15
Error code: E127
```

Change Summary:

Fixed an indentation issue.

Commits:

	Summary	ID
	Fix unit test regressions from recent UI changes. Some of my recent changes impacted some of our Python unit tests. I was a bit sloppy in not running the Python tests for some changes, concentrating more on the JavaScript side. These were mostly string changes that affected comparisons, though there was one piece of broken HTML introduced in `menu_action.html`. These have all been fixed, and all Python tests now pass.	ad5fc4d0f5b80314dac72d2eacb06b31ec4bd19a
	Fix unit test regressions from recent UI changes. Some of my recent changes impacted some of our Python unit tests. I was a bit sloppy in not running the Python tests for some changes, concentrating more on the JavaScript side. These were mostly string changes that affected comparisons, though there was one piece of broken HTML introduced in `menu_action.html`. These have all been fixed, and all Python tests now pass.	4c7d877469bff5f2c02e48dd525266a194a55778

Diff:

Revision 2 (+48 -32)

Show changes

	reviewboard/accounts/tests/test_theme_form.py
	reviewboard/extensions/tests/test_action_hooks.py
	reviewboard/extensions/tests/test_navigation_bar_hook.py
	reviewboard/search/tests/test_search_view.py
	reviewboard/templates/actions/menu_action.html

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-7.x (3bb70ca)