Ensure MenuView elements always have an ID set.

Review Request #13743 — Created April 17, 2024 and submitted

Information

Ink
master

Reviewers

The code setting a default for MenuView's element ID didn't work
correctly. The approach failed to set an ID when the default was an
empty string, and also tried to set the ID too late (initialize() is
called after the element is created).

We now set the ID more explicitly during initialize() and during
render.

Verified that a MenuView used in Review Board had an automatic ID
set, and that MenuViews with an ID didn't have it replaced.

Summary ID
Ensure MenuView elements always have an ID set.
The code setting a default for MenuView's element ID didn't work correctly. The approach failed to set an ID when the default was an empty string, and also tried to set the ID too late (`initialize()` is called after the element is created). We now set the ID more explicitly during `initialize()` and during render.
a4c7bbad78ad788135e4f39eca0682f53d96df3e
david
  1. Ship It!
  2. 
      
maubin
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to master (af27eb5)