flake8
passed.
JSHint
passed.
Review Request #13743 — Created April 17, 2024 and submitted
The code setting a default for MenuView's element ID didn't work
correctly. The approach failed to set an ID when the default was an
empty string, and also tried to set the ID too late (initialize()
is
called after the element is created).We now set the ID more explicitly during
initialize()
and during
render.
Verified that a
MenuView
used in Review Board had an automatic ID
set, and thatMenuView
s with an ID didn't have it replaced.
Summary | ID |
---|---|
a4c7bbad78ad788135e4f39eca0682f53d96df3e |