Update most buttons in the UI to use Ink.Button.

Review Request #13719 — Created April 8, 2024 and submitted

Information

Review Board
release-7.x

Reviewers

This goes through the UI and switches most of our buttons to
Ink.Button. This includes some slight appearance changes, including
different icons, a bit more button padding (making them easier to hit,
especially on mobile), and the capability to mark them as busy when
operations are being performed. The formatting toolbar has some changes
in appearance as well.

Review Board's own buttons, button groups, and menu buttons are now
considered deprecated for new code. If the body tag as the
ink-show-deprecations class applied, these will be highlighted.

There are still buttons that need to be updated, but those will be
tackled in separate changes as part of larger UI work.

Tested various parts of the UI with deprecations turned on, making
sure most were converted over.

Tested in light and dark modes, but dark mode still needs work in many
affected areas before it's fully ready here.

Unit tests pass.

Summary ID
Update most buttons in the UI to use Ink.Button.
This goes through the UI and switches most of our buttons to `Ink.Button`. This includes some slight appearance changes, including different icons, a bit more button padding (making them easier to hit, especially on mobile), and the capability to mark them as busy when operations are being performed. The formatting toolbar has some changes in appearance as well. Review Board's own buttons, button groups, and menu buttons are now considered deprecated for new code. If the `body` tag as the `ink-show-deprecations` class applied, these will be highlighted. There are still buttons that need to be updated, but those will be tackled in separate changes as part of larger UI work.
d7271024907b4a6ea29755be0761a0d1216c44ad

david
  1. 
      
  2. This works?

  3. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-7.x (df5689d)
Loading...