Summary

Use "import type" consistently in our TS code.

Review Request #13713 — Created April 8, 2024 and submitted April 12, 2024, 12:38 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The ability to import something solely for its type information is a new

feature in TypeScript, and makes things easier for the compiler later.

This change updates all our existing code to use it where appropriate,

and makes things consistent so we always use import { type ... }

instead of sometimes having import type { ... }.
This also groups all the type imports before all the regular imports

within each import block.

Testing Done

Ran js-tests.

Commits

Summary	ID
Use "import type" consistently in our TS code. The ability to import something solely for its type information is a new feature in TypeScript, and makes things easier for the compiler later. This change updates all our existing code to use it where appropriate, and makes things consistent so we always use `import { type ... }` instead of sometimes having `import type { ... }`. This also groups all the `type` imports before all the regular imports within each import block. Testing Done: Ran js-tests.	76e897a98458924a87f4e72230ef708d775266ed

Summary

Use "import type" consistently in our TS code.

The ability to import something solely for its type information is a new feature in TypeScript, and makes things easier for the compiler later. This change updates all our existing code to use it where appropriate, and makes things consistent so we always use `import { type ... }` instead of sometimes having `import type { ... }`. This also groups all the `type` imports before all the regular imports within each import block. Testing Done: Ran js-tests.

76e897a98458924a87f4e72230ef708d775266ed

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Description:

		The ability to import something solely for its type information is a new
		feature in TypeScript, and makes things easier for the compiler later.
		This change updates all our existing code to use it where appropriate,
		and makes things consistent so we always use `import { type ... }`
		instead of sometimes having `import type { ... }`.
	+
	+	This also groups all the `type` imports before all the regular imports
	+	within each import block.

Commits:

	Summary	ID
	Use "import type" consistently in our TS code. The ability to import something solely for its type information is a new feature in TypeScript, and makes things easier for the compiler later. This change updates all our existing code to use it where appropriate, and makes things consistent so we always use `import { type ... }` instead of sometimes having `import type { ... }`. Testing Done: Ran js-tests.	abe6ec7918145ffe647eb83acce61543c6fc1af6
	Use "import type" consistently in our TS code. The ability to import something solely for its type information is a new feature in TypeScript, and makes things easier for the compiler later. This change updates all our existing code to use it where appropriate, and makes things consistent so we always use `import { type ... }` instead of sometimes having `import type { ... }`. This also groups all the `type` imports before all the regular imports within each import block. Testing Done: Ran js-tests.	76e897a98458924a87f4e72230ef708d775266ed

Diff:

Revision 2 (+512 -280)

Show changes

	reviewboard/static/rb/js/common/actions/models/menuActionModel.ts
	reviewboard/static/rb/js/common/actions/views/actionView.ts
	reviewboard/static/rb/js/common/actions/views/menuActionView.ts
	reviewboard/static/rb/js/common/models/pageModel.ts
	reviewboard/static/rb/js/common/models/userSessionModel.ts
	reviewboard/static/rb/js/common/resources/collections/resourceCollection.ts
	reviewboard/static/rb/js/common/resources/models/baseCommentModel.ts
	reviewboard/static/rb/js/common/resources/models/baseResourceModel.ts
	55 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-7.x (ec9d301)