Summary

Add support for PMD 7.

Review Request #13710 — Created April 5, 2024 and submitted April 10, 2024, 2:33 p.m.

Information

Owner

david

Repository

ReviewBot

Branch

release-4.x

Bugs

Depends On

Reviewers

Groups

reviewbot

People

Description

PMD just released a big new major version, 7.0.0. This makes a fairly
large change to the basic command-line UI, but is mostly otherwise
compatible.

Some of the output is slightly different for a few of the tests. I've
changed the simulation tests to simulate PMD7, and the integration tests
sometimes need to conditionalize the expected output. We also had one
test (for a config file with no rules) that was obsolete even in PMD
6.55, which treated a file with no active rules as a warning rather than
an error.

Testing Done

Ran unit tests with both PMD 6.55.0 and 7.0.0. Saw that everything
passed.

Commits

Summary	ID
Add support for PMD 7. PMD just released a big new major version, 7.0.0. This makes a fairly large change to the basic command-line UI, but is mostly otherwise compatible. Some of the output is slightly different for a few of the tests. I've changed the simulation tests to simulate PMD7, and the integration tests sometimes need to conditionalize the expected output. We also had one test (for a config file with no rules) that was obsolete even in PMD 6.55, which treated a file with no active rules as a warning rather than an error. Testing Done: Ran unit tests with both PMD 6.55.0 and 7.0.0. Saw that everything passed. Reviewed at https://reviews.reviewboard.org/r/13710/	2e2681f5f5f49cf44c94abb26152cafa9c63bd23

Summary

Add support for PMD 7.

PMD just released a big new major version, 7.0.0. This makes a fairly large change to the basic command-line UI, but is mostly otherwise compatible. Some of the output is slightly different for a few of the tests. I've changed the simulation tests to simulate PMD7, and the integration tests sometimes need to conditionalize the expected output. We also had one test (for a config file with no rules) that was obsolete even in PMD 6.55, which treated a file with no active rules as a warning rather than an error. Testing Done: Ran unit tests with both PMD 6.55.0 and 7.0.0. Saw that everything passed. Reviewed at https://reviews.reviewboard.org/r/13710/

2e2681f5f5f49cf44c94abb26152cafa9c63bd23

Issues

Description	From	Last Updated
'reviewbot.config' imported but unused Column: 1 Error code: F401	reviewbot	April 5, 2024, 10:54 p.m.
undefined name 'Any' Column: 44 Error code: F821	reviewbot	April 5, 2024, 10:54 p.m.
Can we add the "Instance variables" block here?	chipx86	April 9, 2024, 9:06 a.m.
This can be removed.	chipx86	April 9, 2024, 9:06 a.m.
Missing a period.	maubin	April 9, 2024, 9:29 a.m.
Missing a period and typo "Runnind".	maubin	April 9, 2024, 9:29 a.m.
Leftover debug code.	maubin	April 9, 2024, 9:29 a.m.
Missing a period.	maubin	April 9, 2024, 9:29 a.m.

flake8 failed.

JSHint passed.

flake8

bot/reviewbot/tools/tests/test_pmd.py (Diff revision 1)
The issue has been dropped. Show all issues
```
'reviewbot.config' imported but unused

Column: 1
Error code: F401
```
bot/reviewbot/tools/tests/test_pmd.py (Diff revision 1)
The issue has been dropped. Show all issues
```
undefined name 'Any'

Column: 44
Error code: F821
```

Commits:

	Summary	ID
	Add support for PMD 7. PMD just released a big new major version, 7.0.0. This makes a fairly large change to the basic command-line UI, but is mostly otherwise compatible. Some of the output is slightly different for a few of the tests. I've changed the simulation tests to simulate PMD7, and the integration tests sometimes need to conditionalize the expected output. We also had one test (for a config file with no rules) that was obsolete even in PMD 6.55, which treated a file with no active rules as a warning rather than an error. Testing Done: Ran unit tests with both PMD 6.55.0 and 7.0.0. Saw that everything passed.	a359f06b0ea81abd5a631cf4901032c817485287
	Add support for PMD 7. PMD just released a big new major version, 7.0.0. This makes a fairly large change to the basic command-line UI, but is mostly otherwise compatible. Some of the output is slightly different for a few of the tests. I've changed the simulation tests to simulate PMD7, and the integration tests sometimes need to conditionalize the expected output. We also had one test (for a config file with no rules) that was obsolete even in PMD 6.55, which treated a file with no active rules as a warning rather than an error. Testing Done: Ran unit tests with both PMD 6.55.0 and 7.0.0. Saw that everything passed.	6ce0207e244d7732755d43f8063891899dba6f73

Diff:

Revision 2 (+354 -276)

Show changes

	bot/reviewbot/tools/pmd.py
	bot/reviewbot/tools/testing/testcases.py
	bot/reviewbot/tools/tests/test_pmd.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

bot/reviewbot/tools/pmd.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Can we add the "Instance variables" block here?
```
bot/reviewbot/tools/tests/test_pmd.py (Diff revision 2)
The issue has been resolved. Show all issues
```
This can be removed.
```

Commits:

	Summary	ID
	Add support for PMD 7. PMD just released a big new major version, 7.0.0. This makes a fairly large change to the basic command-line UI, but is mostly otherwise compatible. Some of the output is slightly different for a few of the tests. I've changed the simulation tests to simulate PMD7, and the integration tests sometimes need to conditionalize the expected output. We also had one test (for a config file with no rules) that was obsolete even in PMD 6.55, which treated a file with no active rules as a warning rather than an error. Testing Done: Ran unit tests with both PMD 6.55.0 and 7.0.0. Saw that everything passed.	6ce0207e244d7732755d43f8063891899dba6f73
	Add support for PMD 7. PMD just released a big new major version, 7.0.0. This makes a fairly large change to the basic command-line UI, but is mostly otherwise compatible. Some of the output is slightly different for a few of the tests. I've changed the simulation tests to simulate PMD7, and the integration tests sometimes need to conditionalize the expected output. We also had one test (for a config file with no rules) that was obsolete even in PMD 6.55, which treated a file with no active rules as a warning rather than an error. Testing Done: Ran unit tests with both PMD 6.55.0 and 7.0.0. Saw that everything passed.	41f10c675562a2342ac450bddebb05f159f046cb

Diff:

Revision 3 (+364 -276)

Show changes

	bot/reviewbot/tools/pmd.py
	bot/reviewbot/tools/testing/testcases.py
	bot/reviewbot/tools/tests/test_pmd.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

bot/reviewbot/tools/tests/test_pmd.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Missing a period.
```
bot/reviewbot/tools/tests/test_pmd.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Missing a period and typo "Runnind".
```
bot/reviewbot/tools/tests/test_pmd.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Leftover debug code.
```
bot/reviewbot/tools/tests/test_pmd.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Missing a period.
```

Commits:

	Summary	ID
	Add support for PMD 7. PMD just released a big new major version, 7.0.0. This makes a fairly large change to the basic command-line UI, but is mostly otherwise compatible. Some of the output is slightly different for a few of the tests. I've changed the simulation tests to simulate PMD7, and the integration tests sometimes need to conditionalize the expected output. We also had one test (for a config file with no rules) that was obsolete even in PMD 6.55, which treated a file with no active rules as a warning rather than an error. Testing Done: Ran unit tests with both PMD 6.55.0 and 7.0.0. Saw that everything passed.	41f10c675562a2342ac450bddebb05f159f046cb
	Add support for PMD 7. PMD just released a big new major version, 7.0.0. This makes a fairly large change to the basic command-line UI, but is mostly otherwise compatible. Some of the output is slightly different for a few of the tests. I've changed the simulation tests to simulate PMD7, and the integration tests sometimes need to conditionalize the expected output. We also had one test (for a config file with no rules) that was obsolete even in PMD 6.55, which treated a file with no active rules as a warning rather than an error. Testing Done: Ran unit tests with both PMD 6.55.0 and 7.0.0. Saw that everything passed. Reviewed at https://reviews.reviewboard.org/r/13710/	2e2681f5f5f49cf44c94abb26152cafa9c63bd23

Diff:

Revision 4 (+356 -276)

Show changes

	bot/reviewbot/tools/pmd.py
	bot/reviewbot/tools/testing/testcases.py
	bot/reviewbot/tools/tests/test_pmd.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.x (2e2681f)

bot/reviewbot/tools/pmd.py (Diff revision 2)