Add a flag for enabling web-based login and update docs.

Review Request #13702 — Created April 5, 2024 and submitted

Information

RBTools
release-5.x

Reviewers

This adds a .reviewboardrc flag for enabling web-based login, which we leave
off by default. The reason why we leave it off by default is because we don't
currently support web-based login when authenticating RBTools on a remote
system, so it's better to let users opt-in to the feature rather than have
it on by default.

This also includes a couple of other small changes:
1. Updates the docs related to authentication.
2. Fixes a bug where we used the wrong config_key for the open browser
option in rbt login.
3. Allows web-based login to be used when authenticating users through
commands other than rbt login.

  • Tested rbt login, saw that web-based login was turned off by default and
    could use it by passing the --web option or setting WEB_LOGIN in
    .reviewboardrc
  • Tested using rbt status without being logged in, saw that it would bring
    me to web-based login if it was enabled, and prompted for username and
    password if it wasn't enabled.
Summary ID
Add a flag for enabling web-based login and update docs.
a3092c4c3f160f94cfd9e722d08a4c9da94ed84b
Description From Last Updated

Do you also need to update docs/rbtools/rbt/commands/login.rst?

daviddavid

Can you clarify the behavior here?

daviddavid

We should document the version where this is added (.. versionadded:: 5.0)

chipx86chipx86
david
  1. 
      
  2. Show all issues

    Do you also need to update docs/rbtools/rbt/commands/login.rst?

  3. rbtools/commands/login.py (Diff revision 1)
     
     
     
     
    Show all issues

    Can you clarify the behavior here?

  4. 
      
maubin
david
  1. Ship It!
  2. 
      
chipx86
  1. 
      
  2. Show all issues

    We should document the version where this is added (.. versionadded:: 5.0)

  3. 
      
maubin
maubin
Review request changed
Status:
Completed
Change Summary:
Pushed to release-5.x (0f4cc49)