Fix specificity level issues with ink-c-button.

 






 

 


  Review Request #13690
  —
  Created April 2, 2024 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Ink
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  beanbag-misc
 









 
 

  
 






 








 





  


 
 

  
The rules for ink-c-button had states apply directly on the

.ink-c-button class and not bound to variations like

.ink-c-button:link. This led to bad styling in some circumstances, in

particular for active/hover styles on links.


Like other components, these are now specified as rules built upon the

top-level &-bound selector for the component.

 








  


 
 

  
Verified that this fixed active states on some buttons in Review Board.

 







 









 





  








 




 







   

    
    
Diff Revision 1


This is not the most recent revision of the diff. The latest diff is revision 2. See what's changed.

    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Fix specificity level issues with ink-c-button.
     
The rules for `ink-c-button` had states apply directly on the
`.ink-c-button` class and not bound to variations like
`.ink-c-button:link`. This led to bad styling in some circumstances, in
particular for active/hover styles on links.

Like other components, these are now specified as rules built upon the
top-level `&`-bound selector for the component.

    

   
  		
  3fdeac17cddfd409b56390fcc78f2a60cace5841
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      src/ink/less/components/schemas/button.schema.less
     
    

   
  

 










     

    

   

  

  

   
   Loading...