Summary

Fix specificity level issues with ink-c-button.

Review Request #13690 — Created April 2, 2024 and submitted April 9, 2024, 1:51 a.m.

Information

Owner

chipx86

Repository

Ink

Branch

master

Bugs

Depends On

Reviewers

Groups

beanbag-misc

People

Description

The rules for ink-c-button had states apply directly on the

.ink-c-button class and not bound to variations like

.ink-c-button:link. This led to bad styling in some circumstances, in

particular for active/hover styles on links.
Like other components, these are now specified as rules built upon the

top-level &-bound selector for the component.

Testing Done

Verified that this fixed active states on some buttons in Review Board.

Commits

Summary	ID
Fix specificity level issues with ink-c-button. The rules for `ink-c-button` had states apply directly on the `.ink-c-button` class and not bound to variations like `.ink-c-button:link`. This led to bad styling in some circumstances, in particular for active/hover styles on links. Like other components, these are now specified as rules built upon the top-level `&`-bound selector for the component.	4c126adcaaca0307b919ae8132a11d159e223687

Summary

Fix specificity level issues with ink-c-button.

The rules for `ink-c-button` had states apply directly on the `.ink-c-button` class and not bound to variations like `.ink-c-button:link`. This led to bad styling in some circumstances, in particular for active/hover styles on links. Like other components, these are now specified as rules built upon the top-level `&`-bound selector for the component.

4c126adcaaca0307b919ae8132a11d159e223687

Issues

Description	From	Last Updated
Indentation is all over the place here.	david	April 8, 2024, 4:39 p.m.

flake8 passed.

JSHint passed.

src/ink/less/components/schemas/button.schema.less (Diff revision 1)

The issue has been resolved. Show all issues

Indentation is all over the place here.

Change Summary:

Fixed alignment issues in the structure schema.

Commits:

	Summary	ID
	Fix specificity level issues with ink-c-button. The rules for `ink-c-button` had states apply directly on the `.ink-c-button` class and not bound to variations like `.ink-c-button:link`. This led to bad styling in some circumstances, in particular for active/hover styles on links. Like other components, these are now specified as rules built upon the top-level `&`-bound selector for the component.	3fdeac17cddfd409b56390fcc78f2a60cace5841
	Fix specificity level issues with ink-c-button. The rules for `ink-c-button` had states apply directly on the `.ink-c-button` class and not bound to variations like `.ink-c-button:link`. This led to bad styling in some circumstances, in particular for active/hover styles on links. Like other components, these are now specified as rules built upon the top-level `&`-bound selector for the component.	4c126adcaaca0307b919ae8132a11d159e223687

Diff:

Revision 2 (+74 -62)

Show changes

src/ink/less/components/schemas/button.schema.less

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (95d7824)