Fix specificity level issues with ink-c-button.

Review Request #13690 — Created April 2, 2024 and submitted

Information

Ink
master

Reviewers

The rules for ink-c-button had states apply directly on the
.ink-c-button class and not bound to variations like
.ink-c-button:link. This led to bad styling in some circumstances, in
particular for active/hover styles on links.

Like other components, these are now specified as rules built upon the
top-level &-bound selector for the component.

Verified that this fixed active states on some buttons in Review Board.

Summary ID
Fix specificity level issues with ink-c-button.
The rules for `ink-c-button` had states apply directly on the `.ink-c-button` class and not bound to variations like `.ink-c-button:link`. This led to bad styling in some circumstances, in particular for active/hover styles on links. Like other components, these are now specified as rules built upon the top-level `&`-bound selector for the component.
4c126adcaaca0307b919ae8132a11d159e223687
Description From Last Updated

Indentation is all over the place here.

daviddavid
david
  1. 
      
  2. src/ink/less/components/schemas/button.schema.less (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     

    Indentation is all over the place here.

  3. 
      
chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (95d7824)
Loading...