• 
  
    
 
    
 
    

    



    
    
    
    
     
    






    
 
    


 
    



    
 

 

  

  

 

    


  
    





    
 
    



  

    
 
 
    
  
    Switch to aria-orientation for ink-c-button-group orientation control.
    
 
    

    



 
    
 
    

  Review Request #13682
  —
  Created March 30, 2024 and submitted  — Latest diff uploaded 

 
    


    




    




    




 
    
  
    
   Information

  
    



    
 
 
    
  chipx86
 
    

    





    
 
 
    
  Ink
 
    

    





    
 
 
    
  master
 
    

    





    
 
 
    
  
 
    

    





    
 
 
    
  
 
    

    



 
    



 
    
  
    
   Reviewers

  
    



    
 
 
    
  beanbag-misc
 
    

    





    
 
 
    
  
 
    

    



 
    



    


    
 
    




  

    
 
 
    
  
    ink-c-button-group had defined an -is-vertical modifier to control
    
orientation. This has been removed, replacing it with the more
    
accessibility-friendly aria-orientation. This attribute is more
    
explicit about the orientation options, and communicates it to screen
    
readers as well.
    
 
    

    





  

    
 
 
    
  
    Unit tests pass.
    

    Tested the aria-orientation values in Storybook.
    
 
    

    




 
    

    





    
 
    









 




 
    

    




   
    
    
    
    
    
    
    
    

    
    
      
    Commits
    
      
    
        
      
    
    
    

    
    

      
    Files