Summary

Switch to aria-orientation for ink-c-button-group orientation control.

Review Request #13682 — Created March 30, 2024 and submitted April 8, 2024, 8:21 p.m.

Information

Owner

chipx86

Repository

Ink

Branch

master

Bugs

Depends On

Reviewers

Groups

beanbag-misc

People

Description

ink-c-button-group had defined an -is-vertical modifier to control
orientation. This has been removed, replacing it with the more
accessibility-friendly aria-orientation. This attribute is more
explicit about the orientation options, and communicates it to screen
readers as well.

Testing Done

Unit tests pass.

Tested the aria-orientation values in Storybook.

Commits

Summary	ID
Switch to aria-orientation for ink-c-button-group orientation control. `ink-c-button-group` had defined an `-is-vertical` modifier to control orientation. This has been removed, replacing it with the more accessibility-friendly `aria-orientation`. This attribute is more explicit about the orientation options, and communicates it to screen readers as well.	0d0f6ea92b3cd25fb78c48cdcd147018011ab5ee

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (c1a95c1)