Summary

Select correct original file attachment when viewing commit ranges.

Review Request #13675 — Created March 28, 2024 and submitted April 10, 2024, 1:33 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

When viewing a range of commits, we weren't properly choosing the
original file attachment. This change makes it so if there's a
base_filediff present in the diff file information, we load the
attachment that is connected to that filediff.

Testing Done

Posted a change that involved several commits to the same image file.
Selected various commit ranges and got the correct diffs for each commit
range.

Commits

Summary	ID
Select correct original file attachment when viewing commit ranges. When viewing a range of commits, we weren't properly choosing the original file attachment. This change makes it so if there's a `base_filediff` present in the diff file information, we load the attachment that is connected to that filediff. Testing Done: Posted a change that involved several commits to the same image file. Selected various commit ranges and got the correct diffs for each commit range.	9de776fce8b520112bcbd67081a8f988fd1f4ec1

Summary

Select correct original file attachment when viewing commit ranges.

When viewing a range of commits, we weren't properly choosing the original file attachment. This change makes it so if there's a `base_filediff` present in the diff file information, we load the attachment that is connected to that filediff. Testing Done: Posted a change that involved several commits to the same image file. Selected various commit ranges and got the correct diffs for each commit range.

9de776fce8b520112bcbd67081a8f988fd1f4ec1

Issues

Description	From	Last Updated
Can we pass the bool as a keyword argument, so this is more self-documenting?	chipx86	April 2, 2024, 11:10 a.m.
Worth logging the HTTP request?	chipx86	April 2, 2024, 11:10 a.m.

flake8 passed.

JSHint passed.

reviewboard/reviews/views/diff_fragments.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can we pass the bool as a keyword argument, so this is more self-documenting?
```
reviewboard/reviews/views/diff_fragments.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Worth logging the HTTP request?
```

Commits:

	Summary	ID
	Select correct original file attachment when viewing commit ranges. When viewing a range of commits, we weren't properly choosing the original file attachment. This change makes it so if there's a `base_filediff` present in the diff file information, we load the attachment that is connected to that filediff. Testing Done: Posted a change that involved several commits to the same image file. Selected various commit ranges and got the correct diffs for each commit range.	a5e8c27bfa8a677b4e7023215e703b01f0e1b8cc
	Select correct original file attachment when viewing commit ranges. When viewing a range of commits, we weren't properly choosing the original file attachment. This change makes it so if there's a `base_filediff` present in the diff file information, we load the attachment that is connected to that filediff. Testing Done: Posted a change that involved several commits to the same image file. Selected various commit ranges and got the correct diffs for each commit range.	9de776fce8b520112bcbd67081a8f988fd1f4ec1

Diff:

Revision 2 (+52 -36)

Show changes

reviewboard/reviews/views/diff_fragments.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-7.x (51ed01b)