Select correct original file attachment when viewing commit ranges.

Review Request #13675 — Created March 28, 2024 and submitted

Information

Review Board
release-7.x

Reviewers

When viewing a range of commits, we weren't properly choosing the
original file attachment. This change makes it so if there's a
base_filediff present in the diff file information, we load the
attachment that is connected to that filediff.

Posted a change that involved several commits to the same image file.
Selected various commit ranges and got the correct diffs for each commit
range.

Summary ID
Select correct original file attachment when viewing commit ranges.
When viewing a range of commits, we weren't properly choosing the original file attachment. This change makes it so if there's a `base_filediff` present in the diff file information, we load the attachment that is connected to that filediff. Testing Done: Posted a change that involved several commits to the same image file. Selected various commit ranges and got the correct diffs for each commit range.
9de776fce8b520112bcbd67081a8f988fd1f4ec1
Description From Last Updated

Can we pass the bool as a keyword argument, so this is more self-documenting?

chipx86chipx86

Worth logging the HTTP request?

chipx86chipx86
chipx86
  1. 
      
  2. Can we pass the bool as a keyword argument, so this is more self-documenting?

  3. reviewboard/reviews/views/diff_fragments.py (Diff revision 1)
     
     
     
     

    Worth logging the HTTP request?

  4. 
      
david
chipx86
  1. Ship It!
  2. 
      
maubin
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-7.x (51ed01b)
Loading...