Summary

Add type hints for the gettext functions and Underscore compatibility.

Review Request #13668 — Created March 25, 2024 and submitted April 1, 2024, 6:24 p.m.

Information

Owner

chipx86

Repository

babel-plugin-django-gettext

Branch

master

Bugs

Depends On

Reviewers

Groups

beanbag-misc

People

Description

Consumers will want to reference the types in individual files or in a
global.d.ts by including the line:

/// <reference types="babel-plugin-django-gettext"/>

Testing Done

Made use of these new definitions in Djblets and Review Board.

Unit tests pass.

Commits

Summary	ID
Add type hints for the gettext functions and Underscore compatibility. This introduces TypeScript type hints that cover the functions and tagged template literals processed by this plugin. It also includes a shim for Underscore that helps merge the definitions for Underscore's `_` object and the `_` gettext alias. Consumer will want to reference the types in individual files or in a `global.d.ts` by including the line: ``` /// <reference types="babel-plugin-django-gettext"/> ```	ce8476998da0b15f991f1a89700bc6802c343942

Summary

Add type hints for the gettext functions and Underscore compatibility.

This introduces TypeScript type hints that cover the functions and tagged template literals processed by this plugin. It also includes a shim for Underscore that helps merge the definitions for Underscore's `_` object and the `_` gettext alias. Consumer will want to reference the types in individual files or in a `global.d.ts` by including the line: ``` /// <reference types="babel-plugin-django-gettext"/> ```

ce8476998da0b15f991f1a89700bc6802c343942

Issues

Description	From	Last Updated
Typo in description: Consumer -> Consumers	david	April 1, 2024, 6:23 p.m.
Missing semicolon. Column: 49 Error code: W033	reviewbot	March 25, 2024, 11:44 p.m.
Missing semicolon. Column: 34 Error code: W033	reviewbot	March 25, 2024, 11:44 p.m.
Super nit: shouldn't this be tagged as typescript?	david	April 1, 2024, 6:23 p.m.

flake8 passed.

JSHint failed.

JSHint

bin/build.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing semicolon.

Column: 49
Error code: W033
```
bin/build.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing semicolon.

Column: 34
Error code: W033
```

Change Summary:

Fixed missing semicolons.

Commits:

	Summary	ID
	Add type hints for the gettext functions and Underscore compatibility. This introduces TypeScript type hints that cover the functions and tagged template literals processed by this plugin. It also includes a shim for Underscore that helps merge the definitions for Underscore's `_` object and the `_` gettext alias. Consumer will want to reference the types in individual files or in a `global.d.ts` by including the line: ``` /// <reference types="babel-plugin-django-gettext"/> ```	9c1bf166c4919a5fd6803bf3f8802f4a9d9a1e34
	Add type hints for the gettext functions and Underscore compatibility. This introduces TypeScript type hints that cover the functions and tagged template literals processed by this plugin. It also includes a shim for Underscore that helps merge the definitions for Underscore's `_` object and the `_` gettext alias. Consumer will want to reference the types in individual files or in a `global.d.ts` by including the line: ``` /// <reference types="babel-plugin-django-gettext"/> ```	ce8476998da0b15f991f1a89700bc6802c343942

Diff:

Revision 2 (+198)

Show changes

	README.md
	package.json
	bin/build.js
	src/index.d.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

The issue has been resolved. Show all issues
```
Typo in description: Consumer -> Consumers
```

README.md (Diff revision 2)

The issue has been resolved. Show all issues

Super nit: shouldn't this be tagged as typescript?

chipx86 April 1, 2024, 6:23 p.m.

Yeah, I have no idea to be honest if that'll render right everywhere, but let's give it a shot.

Description:

		This introduces TypeScript type hints that cover the functions and
		tagged template literals processed by this plugin. It also includes a
		shim for Underscore that helps merge the definitions for Underscore's
		`_` object and the `_` gettext alias.

~		Consumer will want to reference the types in individual files or in a
	~	Consumers will want to reference the types in individual files or in a
		`global.d.ts` by including the line:



		`/// <reference types="babel-plugin-django-gettext"/>`

Status: Closed (submitted)

Change Summary:

Pushed to master (b5cd4b3)