Summary

Comment serialization cleanup part 5: Convert DiffReviewableCollection

Review Request #13659 — Created March 21, 2024 and submitted April 10, 2024, 1:20 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change converts the DiffReviewableCollection to Typescript and
spina. While not truly necessary for the DiffFile cleanup, it is used in
here, and having this makes it easier to use automated tooling to find
the DiffFile uses.

Testing Done

Ran js-tests.

Commits

Summary	ID
Comment serialization cleanup part 5: Convert DiffReviewableCollection This change converts the DiffReviewableCollection to Typescript and spina. While not truly necessary for the DiffFile cleanup, it is used in here, and having this makes it easier to use automated tooling to find the DiffFile uses. Testing Done: Ran js-tests.	8f6ac0802186652a5acb5a58299fe5106ae19047

Issues

Description	From	Last Updated
Some or all of these can be import type.	chipx86	April 1, 2024, 10:11 p.m.
While it's obvious, we should still document this.	chipx86	April 1, 2024, 10:11 p.m.

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/reviews/collections/diffReviewableCollection.ts (Diff revision 1)

The issue has been resolved. Show all issues

Some or all of these can be import type.

reviewboard/static/rb/js/reviews/collections/diffReviewableCollection.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
While it's obvious, we should still document this.
```

Commits:

	Summary	ID
	Comment serialization cleanup part 5: Convert DiffReviewableCollection This change converts the DiffReviewableCollection to Typescript and spina. While not truly necessary for the DiffFile cleanup, it is used in here, and having this makes it easier to use automated tooling to find the DiffFile uses. Testing Done: Ran js-tests.	37149d2a05354279c584da4ebc46cca14af24d23
	Comment serialization cleanup part 5: Convert DiffReviewableCollection This change converts the DiffReviewableCollection to Typescript and spina. While not truly necessary for the DiffFile cleanup, it is used in here, and having this makes it easier to use automated tooling to find the DiffFile uses. Testing Done: Ran js-tests.	8f6ac0802186652a5acb5a58299fe5106ae19047

Diff:

Revision 2 (+178 -58)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/reviews/index.ts
	reviewboard/static/rb/js/diffviewer/collections/diffReviewableCollection.es6.js
	reviewboard/static/rb/js/diffviewer/collections/tests/diffReviewableCollectionTests.es6.js
	reviewboard/static/rb/js/reviews/collections/tests/index.ts
	reviewboard/static/rb/js/tests/index.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-7.x (5c15e66)