Comment serialization cleanup part 4: Convert DiffFile to TypeScript.
Review Request #13658 — Created March 21, 2024 and submitted — Latest diff uploaded
The DiffFile model is quite simple, just being a data storage mechanism
for information about a file in a diff. This file uses a ton of terrible
names for things, and much of the documentation was just flat-out wrong.
This change converts it to TypeScript and spina, and corrects a bunch of
errors in the documentation about the attributes.This also converts the DiffFileCollection class, which is extremely
small.
Ran js-tests.
Diff Revision 2 (Latest)
orig
1
2
Commits
Files
| reviewboard/staticbundles.py |
|---|
| reviewboard/static/rb/js/diffviewer/collections/diffFileCollection.es6.js |
|---|
| reviewboard/static/rb/js/diffviewer/models/diffFileModel.es6.js |
|---|
| reviewboard/static/rb/js/reviews/index.ts |
|---|
| reviewboard/static/rb/js/reviews/collections/diffFileCollection.ts |
|---|
| reviewboard/static/rb/js/reviews/models/diffFileModel.ts |
|---|
| reviewboard/static/rb/js/reviews/models/diffReviewableModel.ts |
|---|
| reviewboard/static/rb/js/reviews/models/diffViewerPageModel.ts |
|---|
| reviewboard/static/rb/js/diffviewer/models/tests/diffFileModelTests.es6.js |
|---|
| reviewboard/static/rb/js/reviews/models/tests/diffReviewableModelTests.ts |
|---|
| reviewboard/static/rb/js/reviews/models/tests/index.ts |
|---|
| reviewboard/static/rb/js/reviews/views/tests/diffReviewableViewTests.ts |
|---|
| reviewboard/static/rb/js/reviews/views/tests/diffViewerPageViewTests.ts |
|---|