Summary

Comment serialization cleanup part 4: Convert DiffFile to TypeScript.

Review Request #13658 — Created March 21, 2024 and submitted April 10, 2024, 1:20 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The DiffFile model is quite simple, just being a data storage mechanism
for information about a file in a diff. This file uses a ton of terrible
names for things, and much of the documentation was just flat-out wrong.
This change converts it to TypeScript and spina, and corrects a bunch of
errors in the documentation about the attributes.

This also converts the DiffFileCollection class, which is extremely
small.

Testing Done

Ran js-tests.

Commits

Summary	ID
Comment serialization cleanup part 4: Convert DiffFile to TypeScript. The DiffFile model is quite simple, just being a data storage mechanism for information about a file in a diff. This file uses a ton of terrible names for things, and much of the documentation was just flat-out wrong. This change converts it to TypeScript and spina, and corrects a bunch of errors in the documentation about the attributes. This also converts the DiffFileCollection class, which is extremely small. Testing Done: Ran js-tests.	1468c66e9f6f9119b5bdb0c4ddc9310250c67dd8

Summary

Comment serialization cleanup part 4: Convert DiffFile to TypeScript.

The DiffFile model is quite simple, just being a data storage mechanism for information about a file in a diff. This file uses a ton of terrible names for things, and much of the documentation was just flat-out wrong. This change converts it to TypeScript and spina, and corrects a bunch of errors in the documentation about the attributes. This also converts the DiffFileCollection class, which is extremely small. Testing Done: Ran js-tests.

1468c66e9f6f9119b5bdb0c4ddc9310250c67dd8

Issues

Description	From	Last Updated
Missing Version Added (or a Version Changed saying where it moved from).	chipx86	April 1, 2024, 10:05 p.m.
Should probably be import type.	chipx86	April 1, 2024, 10:06 p.m.
Should probably be import type.	chipx86	April 1, 2024, 10:06 p.m.

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/reviews/collections/diffFileCollection.ts (Diff revision 1)

The issue has been dropped. Show all issues

Missing Version Added (or a Version Changed saying where it moved from).

david April 1, 2024, 10:10 p.m.

This has existed with the same symbol name in the same bundle for a long time.

reviewboard/static/rb/js/reviews/models/diffReviewableModel.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Should probably be import type.
```
reviewboard/static/rb/js/reviews/models/diffViewerPageModel.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
Should probably be import type.
```

Commits:

	Summary	ID
	Comment serialization cleanup part 4: Convert DiffFile to TypeScript. The DiffFile model is quite simple, just being a data storage mechanism for information about a file in a diff. This file uses a ton of terrible names for things, and much of the documentation was just flat-out wrong. This change converts it to TypeScript and spina, and corrects a bunch of errors in the documentation about the attributes. This also converts the DiffFileCollection class, which is extremely small. Testing Done: Ran js-tests.	3b42ce06777444fac8913b28f1ed3ba303a80e45
	Comment serialization cleanup part 4: Convert DiffFile to TypeScript. The DiffFile model is quite simple, just being a data storage mechanism for information about a file in a diff. This file uses a ton of terrible names for things, and much of the documentation was just flat-out wrong. This change converts it to TypeScript and spina, and corrects a bunch of errors in the documentation about the attributes. This also converts the DiffFileCollection class, which is extremely small. Testing Done: Ran js-tests.	1468c66e9f6f9119b5bdb0c4ddc9310250c67dd8

Diff:

Revision 2 (+490 -260)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/diffviewer/collections/diffFileCollection.es6.js
	reviewboard/static/rb/js/diffviewer/models/diffFileModel.es6.js
	reviewboard/static/rb/js/reviews/index.ts
	reviewboard/static/rb/js/reviews/collections/diffFileCollection.ts
	reviewboard/static/rb/js/reviews/models/diffFileModel.ts
	reviewboard/static/rb/js/reviews/models/diffReviewableModel.ts
	reviewboard/static/rb/js/reviews/models/diffViewerPageModel.ts
	5 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-7.x (a4486c8)