Comment serialization cleanup part 4: Convert DiffFile to TypeScript.

Review Request #13658 — Created March 21, 2024 and submitted

Information

Review Board
release-7.x

Reviewers

The DiffFile model is quite simple, just being a data storage mechanism
for information about a file in a diff. This file uses a ton of terrible
names for things, and much of the documentation was just flat-out wrong.
This change converts it to TypeScript and spina, and corrects a bunch of
errors in the documentation about the attributes.

This also converts the DiffFileCollection class, which is extremely
small.

Ran js-tests.

Summary ID
Comment serialization cleanup part 4: Convert DiffFile to TypeScript.
The DiffFile model is quite simple, just being a data storage mechanism for information about a file in a diff. This file uses a ton of terrible names for things, and much of the documentation was just flat-out wrong. This change converts it to TypeScript and spina, and corrects a bunch of errors in the documentation about the attributes. This also converts the DiffFileCollection class, which is extremely small. Testing Done: Ran js-tests.
1468c66e9f6f9119b5bdb0c4ddc9310250c67dd8
Description From Last Updated

Missing Version Added (or a Version Changed saying where it moved from).

chipx86chipx86

Should probably be import type.

chipx86chipx86

Should probably be import type.

chipx86chipx86
chipx86
  1. 
      
  2. Missing Version Added (or a Version Changed saying where it moved from).

    1. This has existed with the same symbol name in the same bundle for a long time.

  3. Should probably be import type.

  4. Should probably be import type.

  5. 
      
david
maubin
  1. Ship It!
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-7.x (a4486c8)
Loading...