Comment serialization cleanup part 4: Convert DiffFile to TypeScript.

 






 

 


  Review Request #13658
  —
  Created March 21, 2024 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-7.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
The DiffFile model is quite simple, just being a data storage mechanism

for information about a file in a diff. This file uses a ton of terrible

names for things, and much of the documentation was just flat-out wrong.

This change converts it to TypeScript and spina, and corrects a bunch of

errors in the documentation about the attributes.


This also converts the DiffFileCollection class, which is extremely

small.

 








  


 
 

  
Ran js-tests.

 







 









 





  








 




 







   

    
    
Changes between revision 1 and 2



    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Comment serialization cleanup part 4: Convert DiffFile to TypeScript.
     
The DiffFile model is quite simple, just being a data storage mechanism
for information about a file in a diff. This file uses a ton of terrible
names for things, and much of the documentation was just flat-out wrong.
This change converts it to TypeScript and spina, and corrects a bunch of
errors in the documentation about the attributes.

This also converts the DiffFileCollection class, which is extremely
small.

Testing Done:
Ran js-tests.

    

   
  		
  3b42ce06777444fac8913b28f1ed3ba303a80e45
  David Trowbridge
 


 
  
 
 
  
   
    

     Comment serialization cleanup part 4: Convert DiffFile to TypeScript.
     
The DiffFile model is quite simple, just being a data storage mechanism
for information about a file in a diff. This file uses a ton of terrible
names for things, and much of the documentation was just flat-out wrong.
This change converts it to TypeScript and spina, and corrects a bunch of
errors in the documentation about the attributes.

This also converts the DiffFileCollection class, which is extremely
small.

Testing Done:
Ran js-tests.

    

   
  		
  1468c66e9f6f9119b5bdb0c4ddc9310250c67dd8
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/models/diffReviewableModel.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/models/diffViewerPageModel.ts
     
    

   
  

 










     

    

   

  

  

   
   Loading...