Comment serialization cleanup part 3: Move serializedFields to base.

Review Request #13657 — Created March 21, 2024 and submitted

Information

Review Board
release-7.x

Reviewers

This is step 3 of the comment serialization cleanup. The way that diff
comments are serialized/deserialized is very different from the way that
file attachment comments are handled. For file attachment comments (and
screenshot comments), we automatically pull out several keys from the
first comment in each block's serialized comment array using the block
model's serializedFields list.

Diff comments currently use a very different format, and are
deserialized differently. A later change will update the diff comments
to use the same serialization style as attachment/screenshot comments.
This change prepares for that by moving the serializedFields list down
from FileAttachmentCommentBlock into AbstractCommentBlock.

Ran js-tests.

Summary ID
Comment serialization cleanup part 3: Move serializedFields to base.
This is step 3 of the comment serialization cleanup. The way that diff comments are serialized/deserialized is very different from the way that file attachment comments are handled. For file attachment comments (and screenshot comments), we automatically pull out several keys from the first comment in each block's serialized comment array using the block model's `serializedFields` list. Diff comments currently use a very different format, and are deserialized differently. A later change will update the diff comments to use the same serialization style as attachment/screenshot comments. This change prepares for that by moving the `serializedFields` list down from `FileAttachmentCommentBlock` into `AbstractCommentBlock`. Testing Done: Ran js-tests.
efb75db69ed0fd7dc8cef7354d080922848cd000
Description From Last Updated

This needs a type.

chipx86chipx86

This should be generalized to "comment", instead of "FileAttachmentComment".

maubinmaubin
chipx86
david
maubin
  1. 
      
  2. This should be generalized to "comment", instead of "FileAttachmentComment".

  3. 
      
david
maubin
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-7.x (1305700)
Loading...