Summary

Comment serialization cleanup part 3: Move serializedFields to base.

Review Request #13657 — Created March 21, 2024 and submitted April 10, 2024, 1:20 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-7.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Diff comments currently use a very different format, and are
deserialized differently. A later change will update the diff comments
to use the same serialization style as attachment/screenshot comments.
This change prepares for that by moving the serializedFields list down
from FileAttachmentCommentBlock into AbstractCommentBlock.

Testing Done

Ran js-tests.

Commits

Summary	ID
Comment serialization cleanup part 3: Move serializedFields to base. This is step 3 of the comment serialization cleanup. The way that diff comments are serialized/deserialized is very different from the way that file attachment comments are handled. For file attachment comments (and screenshot comments), we automatically pull out several keys from the first comment in each block's serialized comment array using the block model's `serializedFields` list. Diff comments currently use a very different format, and are deserialized differently. A later change will update the diff comments to use the same serialization style as attachment/screenshot comments. This change prepares for that by moving the `serializedFields` list down from `FileAttachmentCommentBlock` into `AbstractCommentBlock`. Testing Done: Ran js-tests.	efb75db69ed0fd7dc8cef7354d080922848cd000

Summary

Comment serialization cleanup part 3: Move serializedFields to base.

This is step 3 of the comment serialization cleanup. The way that diff comments are serialized/deserialized is very different from the way that file attachment comments are handled. For file attachment comments (and screenshot comments), we automatically pull out several keys from the first comment in each block's serialized comment array using the block model's `serializedFields` list. Diff comments currently use a very different format, and are deserialized differently. A later change will update the diff comments to use the same serialization style as attachment/screenshot comments. This change prepares for that by moving the `serializedFields` list down from `FileAttachmentCommentBlock` into `AbstractCommentBlock`. Testing Done: Ran js-tests.

efb75db69ed0fd7dc8cef7354d080922848cd000

Issues

Description	From	Last Updated
This needs a type.	chipx86	April 1, 2024, 10:03 p.m.
This should be generalized to "comment", instead of "FileAttachmentComment".	maubin	April 4, 2024, 9:28 a.m.

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/reviews/models/abstractCommentBlockModel.ts (Diff revision 1)
The issue has been resolved. Show all issues
```
This needs a type.
```

Commits:

	Summary	ID
	Comment serialization cleanup part 3: Move serializedFields to base. This is step 3 of the comment serialization cleanup. The way that diff comments are serialized/deserialized is very different from the way that file attachment comments are handled. For file attachment comments (and screenshot comments), we automatically pull out several keys from the first comment in each block's serialized comment array using the block model's `serializedFields` list. Diff comments currently use a very different format, and are deserialized differently. A later change will update the diff comments to use the same serialization style as attachment/screenshot comments. This change prepares for that by moving the `serializedFields` list down from `FileAttachmentCommentBlock` into `AbstractCommentBlock`. Testing Done: Ran js-tests.	48c8789249708cd635ff82c2ad4acb70a7d04c92
	Comment serialization cleanup part 3: Move serializedFields to base. This is step 3 of the comment serialization cleanup. The way that diff comments are serialized/deserialized is very different from the way that file attachment comments are handled. For file attachment comments (and screenshot comments), we automatically pull out several keys from the first comment in each block's serialized comment array using the block model's `serializedFields` list. Diff comments currently use a very different format, and are deserialized differently. A later change will update the diff comments to use the same serialization style as attachment/screenshot comments. This change prepares for that by moving the `serializedFields` list down from `FileAttachmentCommentBlock` into `AbstractCommentBlock`. Testing Done: Ran js-tests.	543c250d3db817c04d846fd92a3aeeecda7f6baf

Diff:

Revision 2 (+24 -24)

Show changes

	reviewboard/static/rb/js/reviews/models/abstractCommentBlockModel.ts
	reviewboard/static/rb/js/reviews/models/fileAttachmentCommentBlockModel.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/reviews/models/abstractCommentBlockModel.ts (Diff revision 2)
The issue has been resolved. Show all issues
```
This should be generalized to "comment", instead of "FileAttachmentComment".
```

Commits:

	Summary	ID
	Comment serialization cleanup part 3: Move serializedFields to base. This is step 3 of the comment serialization cleanup. The way that diff comments are serialized/deserialized is very different from the way that file attachment comments are handled. For file attachment comments (and screenshot comments), we automatically pull out several keys from the first comment in each block's serialized comment array using the block model's `serializedFields` list. Diff comments currently use a very different format, and are deserialized differently. A later change will update the diff comments to use the same serialization style as attachment/screenshot comments. This change prepares for that by moving the `serializedFields` list down from `FileAttachmentCommentBlock` into `AbstractCommentBlock`. Testing Done: Ran js-tests.	543c250d3db817c04d846fd92a3aeeecda7f6baf
	Comment serialization cleanup part 3: Move serializedFields to base. This is step 3 of the comment serialization cleanup. The way that diff comments are serialized/deserialized is very different from the way that file attachment comments are handled. For file attachment comments (and screenshot comments), we automatically pull out several keys from the first comment in each block's serialized comment array using the block model's `serializedFields` list. Diff comments currently use a very different format, and are deserialized differently. A later change will update the diff comments to use the same serialization style as attachment/screenshot comments. This change prepares for that by moving the `serializedFields` list down from `FileAttachmentCommentBlock` into `AbstractCommentBlock`. Testing Done: Ran js-tests.	efb75db69ed0fd7dc8cef7354d080922848cd000

Diff:

Revision 3 (+22 -24)

Show changes

	reviewboard/static/rb/js/reviews/models/abstractCommentBlockModel.ts
	reviewboard/static/rb/js/reviews/models/fileAttachmentCommentBlockModel.ts

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-7.x (1305700)