Summary

Fix a couple more places where we were using the old String.strip method.

Review Request #13653 — Created March 21, 2024 and submitted March 26, 2024, 10:21 p.m.

Information

Owner

david

Repository

Djblets

Branch

release-5.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

Long ago, we monkey-patched the String class to include a strip()

method. This is now in the standard library as trim(), and we've

deprecated our version. This change fixes two places that still used it

that I had missed.

Testing Done

Ran js-tests and saw that the deprecation warnings were no longer
showing up in the console.

Commits

Summary	ID
Fix a couple more places where we were using the old String.strip method. Long ago, we monkey-patched the String class to include a `strip()` method. This is now in the standard library as `trim()`, and we've deprecated our version. This change fixes two places that still used it that I had missed. Testing Done: Ran js-tests and saw that the deprecation warnings were no longer showing up in the console.	6bf1b9129e56c5b1180d951edb0a349bfc704229

Summary

Fix a couple more places where we were using the old String.strip method.

Long ago, we monkey-patched the String class to include a `strip()` method. This is now in the standard library as `trim()`, and we've deprecated our version. This change fixes two places that still used it that I had missed. Testing Done: Ran js-tests and saw that the deprecation warnings were no longer showing up in the console.

6bf1b9129e56c5b1180d951edb0a349bfc704229

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.x (91ea4cc)