Summary

Add a Menu Button component.

Review Request #13644 — Created March 18, 2024 and submitted March 28, 2024, 11:16 p.m.

Information

Owner

chipx86

Repository

Ink

Branch

master

Bugs

Depends On

Reviewers

Groups

beanbag-misc

People

Description

The Menu Button is a button that displays a drop-down menu on hover,
click, or keyboard interaction. This can be used to select an action or
change settings for a piece of UI.

Menu Buttons can have a distinct Action Button, which will invoke an
action but will not show the drop-down menu. In this situation, the menu
is generally used for configuration or alternate (but related) actions.

Testing Done

Tested the component thoroughly in Storybook.

Unit tests pass.

Commits

Summary	ID
Add a Menu Button component. The Menu Button is a button that displays a drop-down menu on hover, click, or keyboard interaction. This can be used to select an action or change settings for a piece of UI. Menu Buttons can have a distinct Action Button, which will invoke an action but will not show the drop-down menu. In this situation, the menu is generally used for configuration or alternate (but related) actions.	744744e9eea07d747dd3ceeaf473dc66eb606ca4

Summary

Add a Menu Button component.

The Menu Button is a button that displays a drop-down menu on hover, click, or keyboard interaction. This can be used to select an action or change settings for a piece of UI. Menu Buttons can have a distinct Action Button, which will invoke an action but will not show the drop-down menu. In this situation, the menu is generally used for configuration or alternate (but related) actions.

744744e9eea07d747dd3ceeaf473dc66eb606ca4

Files

Issues

Description	From	Last Updated
Missing a docstring for the file. Also just wondering what this file is for, it's not a component, schema or …	maubin	March 26, 2024, 2:07 a.m.
Is this supposed to be this empty?	maubin	March 26, 2024, 2:06 a.m.

flake8 passed.

JSHint passed.

src/ink/less/components/menu-button.less (Diff revision 1)

The issue has been resolved. Show all issues

Missing a docstring for the file. Also just wondering what this file is for, it's not a component, schema or theme and I notice other components don't have a file like this.

chipx86 March 26, 2024, 2:43 a.m.

Leftover from an old version of all this. This should have been removed. Sorry about that!

src/ink/less/themes/default/components/menu-button.theme.less (Diff revision 1)

The issue has been dropped. Show all issues

Is this supposed to be this empty?

chipx86 March 26, 2024, 2:43 a.m.

Yeah, the idea is that every component has these variables available for use when specializing. They need to be there, even if empty.

Change Summary:


Added properties for customizing the menu button's label, icon, busy state, disabled state, and menu items at runtime.
Added access to the underlying action and dropdown button components.
Removed a legacy file from the change.

Commits:

	Summary	ID
	Add a Menu Button component. The Menu Button is a button that displays a drop-down menu on hover, click, or keyboard interaction. This can be used to select an action or change settings for a piece of UI. Menu Buttons can have a distinct Action Button, which will invoke an action but will not show the drop-down menu. In this situation, the menu is generally used for configuration or alternate (but related) actions.	c9b259e868c62dc0650a944e39ae3e3a0225b1d5
	Add a Menu Button component. The Menu Button is a button that displays a drop-down menu on hover, click, or keyboard interaction. This can be used to select an action or change settings for a piece of UI. Menu Buttons can have a distinct Action Button, which will invoke an action but will not show the drop-down menu. In this situation, the menu is generally used for configuration or alternate (but related) actions.	744744e9eea07d747dd3ceeaf473dc66eb606ca4

Diff:

Revision 2 (+3738 -4)

Show changes

	src/ink/js/components/views/index.ts
	src/ink/js/components/views/menuButtonView.ts
	src/ink/js/components/views/menuView.ts
	src/ink/js/components/views/tests/menuButtonViewTests.ts
	src/ink/less/components/index.less
	src/ink/less/components/menu-button.component.less
	src/ink/less/components/schemas/index.less
	src/ink/less/components/schemas/menu-button.schema.less
	3 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (fdef2c5)