Summary

Fix a crash when the search view is getting indexed.

Review Request #13642 — Created March 18, 2024 and submitted April 1, 2024, 9:57 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

A bad spider is sending some requests to the search view that are

causing error tracebacks. The issue here is that the form isn't valid,

but we were still trying to access cleaned_data. This change fixes

that up and tweaks stuff to make linters/static analysis happy.

Testing Done

Ran unit tests.

Commits

Summary	ID
Fix a crash when the search view is getting indexed. A bad spider is sending some requests to the search view that are causing error tracebacks. The issue here is that the form isn't valid, but we were still trying to access `cleaned_data`. This change fixes that up and tweaks stuff to make linters/static analysis happy. Testing Done: Ran unit tests.	604fc379e673347558460f2e03a751b819f483ae

Issues

Description	From	Last Updated
Is this applicable to 6.x?	chipx86	March 27, 2024, 7:52 a.m.
We need to define the active_filters variable outside of this if statement block too, otherwise if the form is not …	maubin	March 21, 2024, 9:44 p.m.
Missing a comma, newline, and return type.	chipx86	March 27, 2024, 7:52 a.m.

flake8 passed.

JSHint passed.

reviewboard/search/views.py (Diff revision 1)

The issue has been resolved. Show all issues

We need to define the active_filters variable outside of this if statement block too, otherwise if the form is not valid active_filters will be undefined and cause a name error when we try to use it below.

Commits:

	Summary	ID
	Fix a crash when the search view is getting indexed. A bad spider is sending some requests to the search view that are causing error tracebacks. The issue here is that the form isn't valid, but we were still trying to access `cleaned_data`. This change fixes that up and tweaks stuff to make linters/static analysis happy. Testing Done: Ran unit tests.	c081cf839cd88dd435de50c2c6558b67ca34a768
	Fix a crash when the search view is getting indexed. A bad spider is sending some requests to the search view that are causing error tracebacks. The issue here is that the form isn't valid, but we were still trying to access `cleaned_data`. This change fixes that up and tweaks stuff to make linters/static analysis happy. Testing Done: Ran unit tests.	7ace0642f1f99f65b333063d2f501eed406104f0

Diff:

Revision 2 (+30 -10)

Show changes

reviewboard/search/views.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

Is this applicable to 6.x?

chipx86 March 26, 2024, 2:40 p.m.

Actually it is, since that's what's deployed. Let's move that there.

reviewboard/search/views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Missing a comma, newline, and return type.
```

Commits:

	Summary	ID
	Fix a crash when the search view is getting indexed. A bad spider is sending some requests to the search view that are causing error tracebacks. The issue here is that the form isn't valid, but we were still trying to access `cleaned_data`. This change fixes that up and tweaks stuff to make linters/static analysis happy. Testing Done: Ran unit tests.	7ace0642f1f99f65b333063d2f501eed406104f0
	Fix a crash when the search view is getting indexed. A bad spider is sending some requests to the search view that are causing error tracebacks. The issue here is that the form isn't valid, but we were still trying to access `cleaned_data`. This change fixes that up and tweaks stuff to make linters/static analysis happy. Testing Done: Ran unit tests.	604fc379e673347558460f2e03a751b819f483ae

Branch:

release-7.x

release-6.x

Diff:

Revision 3 (+32 -10)

Show changes

reviewboard/search/views.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-6.x (f63bc36)