Fix a crash when the search view is getting indexed.
Review Request #13642 — Created March 18, 2024 and submitted
A bad spider is sending some requests to the search view that are
causing error tracebacks. The issue here is that the form isn't valid,
but we were still trying to accesscleaned_data
. This change fixes
that up and tweaks stuff to make linters/static analysis happy.
Ran unit tests.
-
-
reviewboard/search/views.py (Diff revision 1) We need to define the
active_filters
variable outside of this if statement block too, otherwise if the form is not validactive_filters
will be undefined and cause a name error when we try to use it below.
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+30 -10) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Branch: |
|
|||||||
Diff: |
Revision 3 (+32 -10) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.