Change method of passing request into logging methods.

 






 

 


  Review Request #13632
  —
  Created March 15, 2024 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  rbintegrations
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  rbintegrations
 









 
 

  
 






 








 





  


 
 

  
In order to avoid typechecking warnings, we've changed the official way

of passing the request into the logger to use the extra argument

instead of our own custom arg. This change updates rbintegrations to use

that.

 








  


 
 

  
Ran unit tests, no longer saw deprecation warnings.

 







 









 





  








 




 







   

    
    
Diff Revision 1


This is not the most recent revision of the diff. The latest diff is revision 2. See what's changed.

    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Change method of passing request into logging methods.
     
In order to avoid typechecking warnings, we've changed the official way
of passing the request into the logger to use the `extra` argument
instead of our own custom arg. This change updates rbintegrations to use
that.

Testing Done:
Ran unit tests, no longer saw deprecation warnings.

    

   
  		
  47bf96943ba55abfef97a94b730571acceaf3113
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      rbintegrations/circleci/views.py
     
    

   
  

 



 

  

   
    

     
      
      rbintegrations/travisci/forms.py
     
    

   
  

 



 

  

   
    

     
      
      rbintegrations/travisci/views.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...